[PR #1435] [MERGED] fix: NetworkType null safety issues #4737

Closed
opened 2026-03-23 22:15:36 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1435
Author: @onyicodes
Created: 11/10/2022
Status: Merged
Merged: 11/13/2022
Merged by: @appflowy

Base: mainHead: networktype


📝 Commits (3)

  • bef6e7d fix: Networktype null safety issues
  • 9912f0c chore: update connectivity_plus_platform_interface ^1.2.2
  • 734a955 chore: update network state on Rust side

📊 Changes

4 files changed (+13 additions, -9 deletions)

View changed files

📝 frontend/app_flowy/lib/core/network_monitor.dart (+6 -3)
📝 frontend/app_flowy/pubspec.lock (+2 -2)
📝 frontend/app_flowy/pubspec.yaml (+1 -0)
📝 frontend/rust-lib/flowy-net/src/entities/network_state.rs (+4 -4)

📄 Description

Networktype returns nulls when the connectivity result is vpn resulting to null safety issues. Implemented a case for when the connectivity result is vpn to resolve this issue.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1435 **Author:** [@onyicodes](https://github.com/onyicodes) **Created:** 11/10/2022 **Status:** ✅ Merged **Merged:** 11/13/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `networktype` --- ### 📝 Commits (3) - [`bef6e7d`](https://github.com/AppFlowy-IO/AppFlowy/commit/bef6e7dc9fae2303cc2351f5b868da924d198dcc) fix: Networktype null safety issues - [`9912f0c`](https://github.com/AppFlowy-IO/AppFlowy/commit/9912f0c4c7f817c89dbf7c7e541c32f7bffa6631) chore: update connectivity_plus_platform_interface ^1.2.2 - [`734a955`](https://github.com/AppFlowy-IO/AppFlowy/commit/734a9550c7390bc46bdc7eb2f300b79670f81058) chore: update network state on Rust side ### 📊 Changes **4 files changed** (+13 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/core/network_monitor.dart` (+6 -3) 📝 `frontend/app_flowy/pubspec.lock` (+2 -2) 📝 `frontend/app_flowy/pubspec.yaml` (+1 -0) 📝 `frontend/rust-lib/flowy-net/src/entities/network_state.rs` (+4 -4) </details> ### 📄 Description Networktype returns nulls when the connectivity result is vpn resulting to null safety issues. Implemented a case for when the connectivity result is vpn to resolve this issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:15:36 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#4737
No description provided.