[PR #1465] [MERGED] fix: fix colors for buttons and allow more customization #4755

New issue

Closed

opened 2026-03-23 22:15:41 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:15:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1465
Author: @richardshiue
Created: 11/20/2022
Status: ✅ Merged
Merged: 11/21/2022
Merged by: @appflowy

Base: main ← Head: fix-flowytextbutton

📝 Commits (1)

6a45f6f fix: fix colors for buttons and allow more customization

📊 Changes

8 files changed (+40 additions, -45 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/document/document.dart (+0 -4)
📝 frontend/app_flowy/lib/user/presentation/sign_up_screen.dart (+0 -1)
📝 frontend/app_flowy/lib/user/presentation/skip_log_in_screen.dart (+1 -1)
📝 frontend/app_flowy/lib/workspace/presentation/home/menu/app/create_button.dart (+2 -3)
📝 frontend/app_flowy/lib/workspace/presentation/widgets/float_bubble/question_bubble.dart (+2 -3)
📝 frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart (+10 -7)
📝 frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/icon_button.dart (+3 -2)
📝 frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_button.dart (+22 -24)

📄 Description

The difference is subtle, but notice how the hover color only flashes when the mouse is exiting the button. This patch also defers default font properties of the TextButtons from the child FlowyText if needed.

main:

https://user-images.githubusercontent.com/71320345/202879622-02dfcbd7-7125-497d-b436-915283832b67.mp4

this patch:

https://user-images.githubusercontent.com/71320345/202879633-fa40799e-4054-4044-be8c-1a9c0f53751b.mp4

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1465 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 11/20/2022 **Status:** ✅ Merged **Merged:** 11/21/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix-flowytextbutton` --- ### 📝 Commits (1) - [`6a45f6f`](https://github.com/AppFlowy-IO/AppFlowy/commit/6a45f6f56505b2e056e834cc326dff8042d9892a) fix: fix colors for buttons and allow more customization ### 📊 Changes **8 files changed** (+40 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/document/document.dart` (+0 -4) 📝 `frontend/app_flowy/lib/user/presentation/sign_up_screen.dart` (+0 -1) 📝 `frontend/app_flowy/lib/user/presentation/skip_log_in_screen.dart` (+1 -1) 📝 `frontend/app_flowy/lib/workspace/presentation/home/menu/app/create_button.dart` (+2 -3) 📝 `frontend/app_flowy/lib/workspace/presentation/widgets/float_bubble/question_bubble.dart` (+2 -3) 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart` (+10 -7) 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/icon_button.dart` (+3 -2) 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_button.dart` (+22 -24) </details> ### 📄 Description The difference is subtle, but notice how the hover color only flashes when the mouse is exiting the button. This patch also defers default font properties of the TextButtons from the child FlowyText if needed. main: https://user-images.githubusercontent.com/71320345/202879622-02dfcbd7-7125-497d-b436-915283832b67.mp4 this patch: https://user-images.githubusercontent.com/71320345/202879633-fa40799e-4054-4044-be8c-1a9c0f53751b.mp4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>