[PR #1469] [MERGED] fix: no focus border on date cells #4762

New issue

Closed

opened 2026-03-23 22:15:43 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:15:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1469
Author: @Eakam1007
Created: 11/21/2022
Status: ✅ Merged
Merged: 12/21/2022
Merged by: @appflowy

Base: main ← Head: fix-date-cells-border-1414

📝 Commits (4)

53568b2 fix: no focus border on date cells
3458f43 fix: remove redundant import
584657a refactor: use existing functionality from GridCellWidget for focus border
fa703a0 refactor: use requestBeginFocus override instead of GestureDetector

📊 Changes

1 file changed (+11 additions, -12 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart (+11 -12)

📄 Description

Fixes #1414

Added a focus border to date cells if the popup is open:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1469 **Author:** [@Eakam1007](https://github.com/Eakam1007) **Created:** 11/21/2022 **Status:** ✅ Merged **Merged:** 12/21/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix-date-cells-border-1414` --- ### 📝 Commits (4) - [`53568b2`](https://github.com/AppFlowy-IO/AppFlowy/commit/53568b26393b69782811e27dfe28c70988aa52e1) fix: no focus border on date cells - [`3458f43`](https://github.com/AppFlowy-IO/AppFlowy/commit/3458f43a013daa4684ea97046fbd2a03a93f2d26) fix: remove redundant import - [`584657a`](https://github.com/AppFlowy-IO/AppFlowy/commit/584657a84d49bdc4d38fc8c165610b69f513f19d) refactor: use existing functionality from GridCellWidget for focus border - [`fa703a0`](https://github.com/AppFlowy-IO/AppFlowy/commit/fa703a0eb67122aa98caec9f9b1d454cb26eb3a4) refactor: use requestBeginFocus override instead of GestureDetector ### 📊 Changes **1 file changed** (+11 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart` (+11 -12) </details> ### 📄 Description Fixes #1414 Added a focus border to date cells if the popup is open: <img width="350" alt="image" src="https://user-images.githubusercontent.com/67077705/202935129-8a27ada8-c147-4535-9d76-b8ac1561e054.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>