[PR #1483] [MERGED] chore: select option cell & header editor UI + move to theme.of(context).texttheme #4765

New issue

Closed

opened 2026-03-23 22:15:44 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:15:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1483
Author: @richardshiue
Created: 11/25/2022
Status: ✅ Merged
Merged: 11/30/2022
Merged by: @appflowy

Base: main ← Head: grid-themeofcontext-textstyle-3

📝 Commits (3)

dc11f66 chore: improvements for suffix text in textfields
a0d219e chore: port more const textstyles to theme provider styles
72a0004 chore: select option editor UI improvements

📊 Changes

7 files changed (+107 additions, -95 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/extension.dart (+23 -27)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart (+54 -50)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/text_field.dart (+7 -6)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart (+2 -6)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart (+6 -3)
📝 frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart (+14 -2)

📄 Description

UI changes:

before	after

Lastly, there is no longer an unpleasant extra padding when the tags are completely contained in one row.

https://user-images.githubusercontent.com/71320345/203902908-45ea20d0-ac9a-4d7e-a9b9-a644447c9efa.mp4

https://user-images.githubusercontent.com/71320345/203902012-de70446d-f521-43fe-96b6-9258de95cc74.mp4

other misc. changes:

cell's tags spacing between rows is now the same as the one between columns
some spacing changes in the cell editor (change from scrollview+slivers to listview which simplifies separator building)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1483 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 11/25/2022 **Status:** ✅ Merged **Merged:** 11/30/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `grid-themeofcontext-textstyle-3` --- ### 📝 Commits (3) - [`dc11f66`](https://github.com/AppFlowy-IO/AppFlowy/commit/dc11f668c86baea72cf196bd3f8227d322bae6bd) chore: improvements for suffix text in textfields - [`a0d219e`](https://github.com/AppFlowy-IO/AppFlowy/commit/a0d219e35b006378a17ddad3a71eb46dab55e7d4) chore: port more const textstyles to theme provider styles - [`72a0004`](https://github.com/AppFlowy-IO/AppFlowy/commit/72a000409e20833da627d6c6acfc69c7b5a79ad0) chore: select option editor UI improvements ### 📊 Changes **7 files changed** (+107 additions, -95 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/extension.dart` (+23 -27) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart` (+54 -50) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/text_field.dart` (+7 -6) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart` (+2 -6) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart` (+6 -3) 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart` (+14 -2) </details> ### 📄 Description UI changes: |before | after | |--- | --- | | ![image](https://user-images.githubusercontent.com/71320345/203902419-764b61de-a9d9-4048-925d-210b0f86b8e6.png) | ![image](https://user-images.githubusercontent.com/71320345/203901281-33eef71b-f938-4bdc-b0b6-b82001073bd3.png) | | ![image](https://user-images.githubusercontent.com/71320345/203902659-6d4c9a59-28ed-47e9-8936-22f459d98a9e.png) | ![image](https://user-images.githubusercontent.com/71320345/203901443-65b70941-f8df-4bce-9509-77e5638de9c1.png) | | ![image](https://user-images.githubusercontent.com/71320345/203902482-7ccd514f-405b-4ea0-a905-550387704ff9.png) | ![image](https://user-images.githubusercontent.com/71320345/203902276-6407d956-ea4c-4f1b-8d33-ad912f5c7715.png) | Lastly, there is no longer an unpleasant extra padding when the tags are completely contained in one row. https://user-images.githubusercontent.com/71320345/203902908-45ea20d0-ac9a-4d7e-a9b9-a644447c9efa.mp4 https://user-images.githubusercontent.com/71320345/203902012-de70446d-f521-43fe-96b6-9258de95cc74.mp4 other misc. changes: - cell's tags spacing between rows is now the same as the one between columns - some spacing changes in the cell editor (change from scrollview+slivers to listview which simplifies separator building) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>