[PR #1490] [MERGED] chore: add filter test #4770

New issue

Closed

opened 2026-03-23 22:15:45 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:15:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1490
Author: @appflowy
Created: 11/27/2022
Status: ✅ Merged
Merged: 11/27/2022
Merged by: @appflowy

Base: main ← Head: filter_bloc_test

📝 Commits (2)

60267e6 chore: refactor grid test directory
b6773a7 chore: add filter tests

📊 Changes

11 files changed (+241 additions, -40 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/board/application/card/card_bloc.dart (+0 -1)
📝 frontend/app_flowy/lib/plugins/board/presentation/board_page.dart (+0 -1)
📝 frontend/app_flowy/lib/plugins/grid/application/row/row_cache.dart (+0 -3)
📝 frontend/app_flowy/test/bloc_test/grid_test/cell/select_option_cell_test.dart (+3 -4)
📝 frontend/app_flowy/test/bloc_test/grid_test/field/edit_field_test.dart (+1 -1)
📝 frontend/app_flowy/test/bloc_test/grid_test/filter/create_filter_test.dart (+11 -9)
📝 frontend/app_flowy/test/bloc_test/grid_test/filter/edit_filter_field_test.dart (+3 -2)
➕ frontend/app_flowy/test/bloc_test/grid_test/filter/filter_menu_test.dart (+61 -0)
➕ frontend/app_flowy/test/bloc_test/grid_test/filter/filter_rows_test.dart (+99 -0)
➕ frontend/app_flowy/test/bloc_test/grid_test/filter/filter_util.dart (+42 -0)
📝 frontend/app_flowy/test/bloc_test/grid_test/util.dart (+21 -19)

📄 Description

Test the number of rows after adding a text filter
Test the number of fields that can create a filter after creating a text filter
Test whether the filter menu's filter is changed or not after updating an existing filter

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1490 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 11/27/2022 **Status:** ✅ Merged **Merged:** 11/27/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `filter_bloc_test` --- ### 📝 Commits (2) - [`60267e6`](https://github.com/AppFlowy-IO/AppFlowy/commit/60267e674ec699be30dff4c9f6c8250095e1c07c) chore: refactor grid test directory - [`b6773a7`](https://github.com/AppFlowy-IO/AppFlowy/commit/b6773a732b9e4e3573b21f7ff5195053ec446a2f) chore: add filter tests ### 📊 Changes **11 files changed** (+241 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/board/application/card/card_bloc.dart` (+0 -1) 📝 `frontend/app_flowy/lib/plugins/board/presentation/board_page.dart` (+0 -1) 📝 `frontend/app_flowy/lib/plugins/grid/application/row/row_cache.dart` (+0 -3) 📝 `frontend/app_flowy/test/bloc_test/grid_test/cell/select_option_cell_test.dart` (+3 -4) 📝 `frontend/app_flowy/test/bloc_test/grid_test/field/edit_field_test.dart` (+1 -1) 📝 `frontend/app_flowy/test/bloc_test/grid_test/filter/create_filter_test.dart` (+11 -9) 📝 `frontend/app_flowy/test/bloc_test/grid_test/filter/edit_filter_field_test.dart` (+3 -2) ➕ `frontend/app_flowy/test/bloc_test/grid_test/filter/filter_menu_test.dart` (+61 -0) ➕ `frontend/app_flowy/test/bloc_test/grid_test/filter/filter_rows_test.dart` (+99 -0) ➕ `frontend/app_flowy/test/bloc_test/grid_test/filter/filter_util.dart` (+42 -0) 📝 `frontend/app_flowy/test/bloc_test/grid_test/util.dart` (+21 -19) </details> ### 📄 Description 1. Test the number of rows after adding a text filter 2. Test the number of fields that can create a filter after creating a text filter 3. Test whether the filter menu's filter is changed or not after updating an existing filter --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>