[PR #1489] [MERGED] Fix/filter UI bugs #4771

New issue

Closed

opened 2026-03-23 22:15:45 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:15:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1489
Author: @appflowy
Created: 11/27/2022
Status: ✅ Merged
Merged: 11/27/2022
Merged by: @appflowy

Base: main ← Head: fix/filter_ui_bugs

📝 Commits (7)

1c5efb3 chore: remove the add filter button if there is no filters can not be added
a107a0c fix: update field info after filter was changed
4a33934 chore: update filter choicechip ui
f928b5d chore: insert and delete one by one to keep the delete/insert index is right
03a8eb7 chore: show filter after creating the default filter
49493e6 chore: update textfield_tags version to calm the warnings
f3f044d chore: try to fix potential fails on backend test

📊 Changes

23 files changed (+251 additions, -136 deletions)

View changed files

📝 frontend/app_flowy/assets/translations/en.json (+8 -1)
📝 frontend/app_flowy/lib/plugins/grid/application/field/field_controller.dart (+5 -3)
📝 frontend/app_flowy/lib/plugins/grid/application/filter/filter_create_bloc.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/grid/application/filter/filter_menu_bloc.dart (+31 -4)
📝 frontend/app_flowy/lib/plugins/grid/application/filter/text_filter_editor_bloc.dart (+17 -17)
📝 frontend/app_flowy/lib/plugins/grid/application/row/row_cache.dart (+27 -25)
📝 frontend/app_flowy/lib/plugins/grid/application/row/row_list.dart (+10 -5)
📝 frontend/app_flowy/lib/plugins/grid/presentation/grid_page.dart (+9 -13)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/choicechip/choicechip.dart (+26 -5)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/choicechip/text.dart (+81 -25)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/create_filter_list.dart (+3 -0)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/menu.dart (+5 -8)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/filter_button.dart (+5 -0)
📝 frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart (+1 -2)
📝 frontend/app_flowy/pubspec.lock (+1 -1)
📝 frontend/app_flowy/pubspec.yaml (+1 -1)
📝 frontend/app_flowy/test/bloc_test/home_test/app_bloc_test.dart (+3 -1)
📝 frontend/rust-lib/flowy-document/src/services/migration.rs (+2 -5)
📝 frontend/rust-lib/flowy-grid/src/services/filter/controller.rs (+6 -7)
📝 frontend/rust-lib/flowy-grid/src/services/group/controller_impls/select_option_controller/util.rs (+1 -1)

...and 3 more files

📄 Description

Show the filters after creating the default filter
Insert/Delete rows one by one in order to keep the index right
Show the filter's condition in filter item

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1489 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 11/27/2022 **Status:** ✅ Merged **Merged:** 11/27/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/filter_ui_bugs` --- ### 📝 Commits (7) - [`1c5efb3`](https://github.com/AppFlowy-IO/AppFlowy/commit/1c5efb363b0d7b0f130a1787feca5b50f4bccafb) chore: remove the add filter button if there is no filters can not be added - [`a107a0c`](https://github.com/AppFlowy-IO/AppFlowy/commit/a107a0cffa301dca601a85b688161f8b1ac89a83) fix: update field info after filter was changed - [`4a33934`](https://github.com/AppFlowy-IO/AppFlowy/commit/4a33934333fff49bd4f59c8544e4714a9b158b7e) chore: update filter choicechip ui - [`f928b5d`](https://github.com/AppFlowy-IO/AppFlowy/commit/f928b5d19cec66f0e6e60d157a10211871d5e73d) chore: insert and delete one by one to keep the delete/insert index is right - [`03a8eb7`](https://github.com/AppFlowy-IO/AppFlowy/commit/03a8eb72bf4285f2fa954c384ddfaf532c3359c8) chore: show filter after creating the default filter - [`49493e6`](https://github.com/AppFlowy-IO/AppFlowy/commit/49493e682e882044d220fa00c31aa9b1a04a5b63) chore: update textfield_tags version to calm the warnings - [`f3f044d`](https://github.com/AppFlowy-IO/AppFlowy/commit/f3f044dcc814cbd53171cf5bfd0d84e6765fff03) chore: try to fix potential fails on backend test ### 📊 Changes **23 files changed** (+251 additions, -136 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/assets/translations/en.json` (+8 -1) 📝 `frontend/app_flowy/lib/plugins/grid/application/field/field_controller.dart` (+5 -3) 📝 `frontend/app_flowy/lib/plugins/grid/application/filter/filter_create_bloc.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/grid/application/filter/filter_menu_bloc.dart` (+31 -4) 📝 `frontend/app_flowy/lib/plugins/grid/application/filter/text_filter_editor_bloc.dart` (+17 -17) 📝 `frontend/app_flowy/lib/plugins/grid/application/row/row_cache.dart` (+27 -25) 📝 `frontend/app_flowy/lib/plugins/grid/application/row/row_list.dart` (+10 -5) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/grid_page.dart` (+9 -13) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/choicechip/choicechip.dart` (+26 -5) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/choicechip/text.dart` (+81 -25) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/create_filter_list.dart` (+3 -0) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/menu.dart` (+5 -8) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/filter_button.dart` (+5 -0) 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart` (+1 -2) 📝 `frontend/app_flowy/pubspec.lock` (+1 -1) 📝 `frontend/app_flowy/pubspec.yaml` (+1 -1) 📝 `frontend/app_flowy/test/bloc_test/home_test/app_bloc_test.dart` (+3 -1) 📝 `frontend/rust-lib/flowy-document/src/services/migration.rs` (+2 -5) 📝 `frontend/rust-lib/flowy-grid/src/services/filter/controller.rs` (+6 -7) 📝 `frontend/rust-lib/flowy-grid/src/services/group/controller_impls/select_option_controller/util.rs` (+1 -1) _...and 3 more files_ </details> ### 📄 Description 1. Show the filters after creating the default filter 2. Insert/Delete rows one by one in order to keep the index right 3. Show the filter's condition in filter item --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>