[PR #1513] [MERGED] feat: add hover effect when trash icon is selected or hovered. #4789

New issue

Closed

opened 2026-03-23 22:15:50 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:15:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1513
Author: @rasyidmi
Created: 11/30/2022
Status: ✅ Merged
Merged: 12/8/2022
Merged by: @appflowy

Base: main ← Head: main

📝 Commits (1)

40cbf91 feat: add hover effect when trash icon is selected or hovered.

📊 Changes

2 files changed (+28 additions, -12 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/trash/menu.dart (+26 -11)
📝 frontend/app_flowy/lib/workspace/presentation/home/menu/menu.dart (+2 -1)

📄 Description

Hello AppFlowy. I am creating this PR to solve issue on this link.

Remove padding(horizontal: Insets.l), in line 103 so the hover effect width can match the container.
Add ValueListneableBuilder so MenuTrash widget can update their state when clicked or unclicked.

The video of the result is here

This is the updated PR from previous attempt on this link.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1513 **Author:** [@rasyidmi](https://github.com/rasyidmi) **Created:** 11/30/2022 **Status:** ✅ Merged **Merged:** 12/8/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`40cbf91`](https://github.com/AppFlowy-IO/AppFlowy/commit/40cbf912d32e4b637315e70146e3044bd0b07cf5) feat: add hover effect when trash icon is selected or hovered. ### 📊 Changes **2 files changed** (+28 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/trash/menu.dart` (+26 -11) 📝 `frontend/app_flowy/lib/workspace/presentation/home/menu/menu.dart` (+2 -1) </details> ### 📄 Description Hello AppFlowy. I am creating this PR to solve issue on this [link](https://github.com/AppFlowy-IO/AppFlowy/issues/834). 1. Remove `padding(horizontal: Insets.l),` in line 103 so the hover effect width can match the container. 2. Add `ValueListneableBuilder` so MenuTrash widget can update their state when clicked or unclicked. The video of the result is [here](https://drive.google.com/file/d/1qDIW75iBAvYm42zlHyRYxr7m-LSKSS1G/view?usp=share_link) This is the updated PR from previous attempt on this [link](https://github.com/AppFlowy-IO/AppFlowy/pull/1486). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>