[PR #1578] [MERGED] Refactor/type option #4832

Closed
opened 2026-03-23 22:16:01 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1578
Author: @appflowy
Created: 12/17/2022
Status: Merged
Merged: 12/17/2022
Merged by: @appflowy

Base: mainHead: refactor/type_option


📝 Commits (5)

  • b0fb8c7 chore: sort cell
  • e869a69 refactor: cell data parser
  • 48a5b9c refactor: cell data traits
  • c52759e chore: support encode data if pb type is not string
  • b3e7804 chore: format code & remove unused code

📊 Changes

43 files changed (+966 additions, -616 deletions)

View changed files

📝 frontend/rust-lib/flowy-grid/src/event_handler.rs (+4 -3)
📝 frontend/rust-lib/flowy-grid/src/lib.rs (+2 -0)
📝 frontend/rust-lib/flowy-grid/src/services/cell/cell_operation.rs (+74 -186)
📝 frontend/rust-lib/flowy-grid/src/services/cell/type_cell_data.rs (+52 -34)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_filter.rs (+9 -6)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_tests.rs (+3 -2)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_type_option.rs (+40 -29)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_type_option_entities.rs (+15 -3)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_filter.rs (+12 -7)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_tests.rs (+4 -5)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_type_option.rs (+44 -33)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_type_option_entities.rs (+13 -10)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/mod.rs (+2 -1)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_filter.rs (+7 -3)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_tests.rs (+3 -2)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option.rs (+50 -30)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option_entities.rs (+5 -3)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/selection_type_option/checklist_type_option.rs (+28 -16)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/selection_type_option/multi_select_type_option.rs (+29 -17)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/selection_type_option/select_filter.rs (+12 -8)

...and 23 more files

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1578 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 12/17/2022 **Status:** ✅ Merged **Merged:** 12/17/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `refactor/type_option` --- ### 📝 Commits (5) - [`b0fb8c7`](https://github.com/AppFlowy-IO/AppFlowy/commit/b0fb8c74ae1a4d9f29c55baa1953756ca663abc6) chore: sort cell - [`e869a69`](https://github.com/AppFlowy-IO/AppFlowy/commit/e869a692779554cc7e2f34875b1ff4575f54de7d) refactor: cell data parser - [`48a5b9c`](https://github.com/AppFlowy-IO/AppFlowy/commit/48a5b9c801cdfbd8ab580f7d4bda240b1351f87b) refactor: cell data traits - [`c52759e`](https://github.com/AppFlowy-IO/AppFlowy/commit/c52759ebbf5d7c99082a654a5f346586eb9a28ef) chore: support encode data if pb type is not string - [`b3e7804`](https://github.com/AppFlowy-IO/AppFlowy/commit/b3e780413714d2ca8c73db5c9b9fe48893149a9f) chore: format code & remove unused code ### 📊 Changes **43 files changed** (+966 additions, -616 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-grid/src/event_handler.rs` (+4 -3) 📝 `frontend/rust-lib/flowy-grid/src/lib.rs` (+2 -0) 📝 `frontend/rust-lib/flowy-grid/src/services/cell/cell_operation.rs` (+74 -186) 📝 `frontend/rust-lib/flowy-grid/src/services/cell/type_cell_data.rs` (+52 -34) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_filter.rs` (+9 -6) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_tests.rs` (+3 -2) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_type_option.rs` (+40 -29) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_type_option_entities.rs` (+15 -3) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_filter.rs` (+12 -7) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_tests.rs` (+4 -5) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_type_option.rs` (+44 -33) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_type_option_entities.rs` (+13 -10) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/mod.rs` (+2 -1) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_filter.rs` (+7 -3) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_tests.rs` (+3 -2) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option.rs` (+50 -30) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option_entities.rs` (+5 -3) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/selection_type_option/checklist_type_option.rs` (+28 -16) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/selection_type_option/multi_select_type_option.rs` (+29 -17) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/selection_type_option/select_filter.rs` (+12 -8) _...and 23 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:16:01 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#4832
No description provided.