[PR #1602] [MERGED] fix: button spacing for grid menus #4845

New issue

Closed

opened 2026-03-23 22:16:05 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1602
Author: @richardshiue
Created: 12/22/2022
Status: ✅ Merged
Merged: 12/24/2022
Merged by: @appflowy

Base: main ← Head: align-start-of-text

📝 Commits (2)

f3f81f1 chore: don't put extra space in front of text
6369d6d chore: alter button margins for date and time format buttons

📊 Changes

12 files changed (+299 additions, -283 deletions)

View changed files

📝 frontend/app_flowy/assets/translations/en.json (+4 -4)
📝 frontend/app_flowy/assets/translations/fr-FR.json (+4 -4)
📝 frontend/app_flowy/assets/translations/id-ID.json (+4 -4)
📝 frontend/app_flowy/assets/translations/ja-JP.json (+4 -4)
📝 frontend/app_flowy/assets/translations/ko-KR.json (+231 -232)
📝 frontend/app_flowy/assets/translations/ru-RU.json (+4 -4)
📝 frontend/app_flowy/assets/translations/sv.json (+4 -4)
📝 frontend/app_flowy/assets/translations/zh-CN.json (+4 -4)
📝 frontend/app_flowy/assets/translations/zh-TW.json (+4 -4)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart (+2 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/date.dart (+27 -12)
📝 frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart (+7 -6)

📄 Description

We should be adding custom padding using Padding instead of space characters when necessary
Padding for lists in popovers should be 10 horizontally, and 6 horizontally if there are other elements

Before	After

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1602 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/22/2022 **Status:** ✅ Merged **Merged:** 12/24/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `align-start-of-text` --- ### 📝 Commits (2) - [`f3f81f1`](https://github.com/AppFlowy-IO/AppFlowy/commit/f3f81f1808c6e5d96083c15fc56d01265698cd0c) chore: don't put extra space in front of text - [`6369d6d`](https://github.com/AppFlowy-IO/AppFlowy/commit/6369d6df4b17a826c39a58ff46454aef22a51819) chore: alter button margins for date and time format buttons ### 📊 Changes **12 files changed** (+299 additions, -283 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/assets/translations/en.json` (+4 -4) 📝 `frontend/app_flowy/assets/translations/fr-FR.json` (+4 -4) 📝 `frontend/app_flowy/assets/translations/id-ID.json` (+4 -4) 📝 `frontend/app_flowy/assets/translations/ja-JP.json` (+4 -4) 📝 `frontend/app_flowy/assets/translations/ko-KR.json` (+231 -232) 📝 `frontend/app_flowy/assets/translations/ru-RU.json` (+4 -4) 📝 `frontend/app_flowy/assets/translations/sv.json` (+4 -4) 📝 `frontend/app_flowy/assets/translations/zh-CN.json` (+4 -4) 📝 `frontend/app_flowy/assets/translations/zh-TW.json` (+4 -4) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart` (+2 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/date.dart` (+27 -12) 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart` (+7 -6) </details> ### 📄 Description - We should be adding custom padding using `Padding` instead of space characters when necessary - Padding for lists in popovers should be 10 horizontally, and 6 horizontally if there are other elements |Before|After| |:--:|:--:| |![image](https://user-images.githubusercontent.com/71320345/209078655-abaf2625-eef8-4233-a5a5-b504947af71c.png) |![image](https://user-images.githubusercontent.com/71320345/209078520-58b949c0-c8ee-4b97-a998-81d96846806d.png) | |![image](https://user-images.githubusercontent.com/71320345/209084701-8b89cb29-3ba0-412d-a0c4-a70a119d34f7.png) | ![image](https://user-images.githubusercontent.com/71320345/209084642-95867a6a-910c-49f5-9f55-d4c0f81cc5c7.png) | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>