[PR #1605] [MERGED] feat: show the scrollbars again #4847

New issue

Closed

opened 2026-03-23 22:16:05 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1605
Author: @richardshiue
Created: 12/24/2022
Status: ✅ Merged
Merged: 12/27/2022
Merged by: @appflowy

Base: main ← Head: number-editor-redesign

📝 Commits (8)

1ef21ac fix: padding in grid cell editors
3b7b45f fix: padding in grid header editor
8bf4315 fix: padding for row details
ac8482e fix: shrink number formt list when possible
21d1785 chore: simply use column for select option editor
cce1f3a fix: make sure that popovers are the edges
81fcae3 fix: delete button padding
05c663d fix: date and time formats padding mistake

📊 Changes

16 files changed (+437 additions, -343 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/grid/presentation/layout/sizes.dart (+0 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart (+91 -68)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart (+1 -0)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart (+108 -108)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/type_option_separator.dart (+3 -2)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart (+1 -0)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell_action_sheet.dart (+5 -3)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart (+39 -39)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_option_editor.dart (+5 -2)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/date.dart (+42 -28)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/number.dart (+27 -15)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart (+73 -56)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option_editor.dart (+25 -20)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/row/row_detail.dart (+1 -0)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/grid_property.dart (+1 -0)
📝 frontend/app_flowy/lib/workspace/application/appearance.dart (+15 -1)

📄 Description

This PR shows the scrollbars in the menus again, but some other changes have to be made to the menus since the padding on the scrollviews also insets the scrollbars. Also, with this patch, nested popovers now sit side by side properly, rather than overlapping a small portion near the edge of the parent

Field Type
Text and Number
Date
Select

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1605 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/24/2022 **Status:** ✅ Merged **Merged:** 12/27/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `number-editor-redesign` --- ### 📝 Commits (8) - [`1ef21ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/1ef21acade50a324833bcdb3f45d1b7c86d935bd) fix: padding in grid cell editors - [`3b7b45f`](https://github.com/AppFlowy-IO/AppFlowy/commit/3b7b45f03207119bdf493db5301047baf20e5779) fix: padding in grid header editor - [`8bf4315`](https://github.com/AppFlowy-IO/AppFlowy/commit/8bf431569ffbcbd1c1d363cae07b3eccc575ab16) fix: padding for row details - [`ac8482e`](https://github.com/AppFlowy-IO/AppFlowy/commit/ac8482e5b23a7f9358ca19525a21ad7ff56bc2ed) fix: shrink number formt list when possible - [`21d1785`](https://github.com/AppFlowy-IO/AppFlowy/commit/21d17852c6eae1a20e9b43d888a8185e1ec5c512) chore: simply use column for select option editor - [`cce1f3a`](https://github.com/AppFlowy-IO/AppFlowy/commit/cce1f3ae526f29a81a1148625fc45df1e8055ffd) fix: make sure that popovers are the edges - [`81fcae3`](https://github.com/AppFlowy-IO/AppFlowy/commit/81fcae3c5e7220c8af7c2ce80247e050285b33f0) fix: delete button padding - [`05c663d`](https://github.com/AppFlowy-IO/AppFlowy/commit/05c663ddae6b7376dd854f1f8ae1e0882ab013d2) fix: date and time formats padding mistake ### 📊 Changes **16 files changed** (+437 additions, -343 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/grid/presentation/layout/sizes.dart` (+0 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart` (+91 -68) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart` (+1 -0) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart` (+108 -108) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/type_option_separator.dart` (+3 -2) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart` (+1 -0) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell_action_sheet.dart` (+5 -3) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart` (+39 -39) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_option_editor.dart` (+5 -2) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/date.dart` (+42 -28) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/number.dart` (+27 -15) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart` (+73 -56) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option_editor.dart` (+25 -20) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/row/row_detail.dart` (+1 -0) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/grid_property.dart` (+1 -0) 📝 `frontend/app_flowy/lib/workspace/application/appearance.dart` (+15 -1) </details> ### 📄 Description This PR shows the scrollbars in the menus again, but some other changes have to be made to the menus since the padding on the scrollviews also insets the scrollbars. Also, with this patch, nested popovers now sit side by side properly, rather than overlapping a small portion near the edge of the parent |Field Type|| |:-:|:-:| |Text and Number|<video width=100 height=50% src="https://user-images.githubusercontent.com/71320345/209442410-c2acf085-ee2d-4620-b44a-3d32f132b15a.mp4"></video>| |Date|<video src="https://user-images.githubusercontent.com/71320345/209442572-3bbd8f14-59db-43cb-85e2-877a667ff519.mp4"></video>| |Select|<video src="https://user-images.githubusercontent.com/71320345/209442696-c066c6ab-10b0-4056-a742-13b3093867d8.mp4"></video>| --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>