[PR #1625] [MERGED] chore: add spacing between a popover and the edge of the window #4856

New issue

Closed

opened 2026-03-23 22:16:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1625
Author: @richardshiue
Created: 12/31/2022
Status: ✅ Merged
Merged: 1/1/2023
Merged by: @appflowy

Base: main ← Head: popover-edge

📝 Commits (1)

2b2d20d chore: add spacing between a popover and the edge of the window

📊 Changes

3 files changed (+37 additions, -3 deletions)

View changed files

📝 frontend/app_flowy/packages/appflowy_popover/lib/src/layout.dart (+23 -3)
📝 frontend/app_flowy/packages/appflowy_popover/lib/src/popover.dart (+11 -0)
📝 frontend/app_flowy/packages/flowy_infra_ui/lib/src/flowy_overlay/appflowy_popover.dart (+3 -0)

📄 Description

Flutter doesn't currently allow popups to go outside the application window. Because of this, popovers have an unpolished look when they are about go off-canvas. This PR adds a spacing between the popover and the edge of the window.

We can improve this even further by automatically switching to the other side if there isn't enough space on side where the popover is supposed to spawn.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1625 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/31/2022 **Status:** ✅ Merged **Merged:** 1/1/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `popover-edge` --- ### 📝 Commits (1) - [`2b2d20d`](https://github.com/AppFlowy-IO/AppFlowy/commit/2b2d20dc49f5a7719001fb77e3e2cdf96bb1bb98) chore: add spacing between a popover and the edge of the window ### 📊 Changes **3 files changed** (+37 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/appflowy_popover/lib/src/layout.dart` (+23 -3) 📝 `frontend/app_flowy/packages/appflowy_popover/lib/src/popover.dart` (+11 -0) 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/src/flowy_overlay/appflowy_popover.dart` (+3 -0) </details> ### 📄 Description Flutter doesn't currently allow popups to go outside the application window. Because of this, popovers have an unpolished look when they are about go off-canvas. This PR adds a spacing between the popover and the edge of the window. We can improve this even further by automatically switching to the other side if there isn't enough space on side where the popover is supposed to spawn. ![image](https://user-images.githubusercontent.com/71320345/210138598-6085f7f3-8881-4705-918c-5996d2e0cbe5.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>