[PR #1640] [MERGED] chore: add close button in select option tags for select option textfield #4870

New issue

Closed

opened 2026-03-23 22:16:11 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1640
Author: @richardshiue
Created: 1/3/2023
Status: ✅ Merged
Merged: 1/4/2023
Merged by: @appflowy

Base: main ← Head: select-option

📝 Commits (3)

8465a76 chore: remove unused isSelected flag
95ebfe4 chore: close popover when an option is deleted
cfedecd chore: allow unselecting an option by clicking on a close button

📊 Changes

4 files changed (+67 additions, -24 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/extension.dart (+32 -6)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart (+8 -0)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/text_field.dart (+26 -18)
📝 frontend/app_flowy/test/widget_test/select_option_text_field_test.dart (+1 -0)

📄 Description

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1640 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 1/3/2023 **Status:** ✅ Merged **Merged:** 1/4/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `select-option` --- ### 📝 Commits (3) - [`8465a76`](https://github.com/AppFlowy-IO/AppFlowy/commit/8465a767f22088cc9d1da2bfb4d70771522a90b1) chore: remove unused isSelected flag - [`95ebfe4`](https://github.com/AppFlowy-IO/AppFlowy/commit/95ebfe4c450c64c3c119017d1b0aa95b6c1f1de1) chore: close popover when an option is deleted - [`cfedecd`](https://github.com/AppFlowy-IO/AppFlowy/commit/cfedecd50daf6b3d9e1826d915d65bedc90672a9) chore: allow unselecting an option by clicking on a close button ### 📊 Changes **4 files changed** (+67 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/extension.dart` (+32 -6) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart` (+8 -0) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/text_field.dart` (+26 -18) 📝 `frontend/app_flowy/test/widget_test/select_option_text_field_test.dart` (+1 -0) </details> ### 📄 Description ![image](https://user-images.githubusercontent.com/71320345/210348571-dff6bd66-9f93-4641-b28d-e9be6a1c01b1.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>