[PR #1652] [MERGED] fix: update the cell content if input is not valid data #4882

New issue

Closed

opened 2026-03-23 22:16:14 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1652
Author: @appflowy
Created: 1/5/2023
Status: ✅ Merged
Merged: 1/5/2023
Merged by: @LucasXu0

Base: main ← Head: fix/number_cell_data_update

📝 Commits (1)

3ddc3d4 fix: update the cell content if input is not valid data

📊 Changes

7 files changed (+98 additions, -58 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/grid/application/cell/cell_service/cell_controller.dart (+46 -13)
📝 frontend/app_flowy/lib/plugins/grid/application/cell/date_cal_bloc.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/grid/application/cell/number_cell_bloc.dart (+32 -26)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/number_cell.dart (+5 -11)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option_entities.rs (+3 -2)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/type_option_cell.rs (+11 -4)
📝 frontend/rust-lib/flowy-user/src/services/database.rs (+0 -1)

📄 Description

If the initial input content is: "", then after entering an invalid number string, the cell content will be empty. The cellDataNofitier doesn't notify the listener because the new value is the same as the old one. aka, "", the empty string.

Add listenWhenOnCellChanged callback to let the caller design how to handle the value change notification.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1652 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 1/5/2023 **Status:** ✅ Merged **Merged:** 1/5/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/number_cell_data_update` --- ### 📝 Commits (1) - [`3ddc3d4`](https://github.com/AppFlowy-IO/AppFlowy/commit/3ddc3d40b5f36445f9c16a065f2e9a56b9740f1f) fix: update the cell content if input is not valid data ### 📊 Changes **7 files changed** (+98 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/grid/application/cell/cell_service/cell_controller.dart` (+46 -13) 📝 `frontend/app_flowy/lib/plugins/grid/application/cell/date_cal_bloc.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/grid/application/cell/number_cell_bloc.dart` (+32 -26) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/number_cell.dart` (+5 -11) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option_entities.rs` (+3 -2) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/type_option_cell.rs` (+11 -4) 📝 `frontend/rust-lib/flowy-user/src/services/database.rs` (+0 -1) </details> ### 📄 Description If the initial input content is: "", then after entering an invalid number string, the cell content will be empty. The cellDataNofitier doesn't notify the listener because the new value is the same as the old one. aka, "", the empty string. Add `listenWhenOnCellChanged` callback to let the caller design how to handle the value change notification. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>