[PR #1735] [MERGED] chore: improve grid focus and hover event handling #4920

New issue

Closed

opened 2026-03-23 22:16:25 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:25 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1735
Author: @richardshiue
Created: 1/23/2023
Status: ✅ Merged
Merged: 1/27/2023
Merged by: @appflowy

Base: main ← Head: grid-focus-accessory-border

📝 Commits (6)

5b897f6 chore: improve primary cell accessory behavior
87ef97f fix: focus border disappearing
5197036 chore: port to GridCellState
b6b9707 chore: fix typo
0f2b2f4 chore: connect popover controller
2d65875 chore: final

📊 Changes

8 files changed (+109 additions, -122 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/board/presentation/card/board_checklist_cell.dart (+5 -2)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_accessory.dart (+8 -12)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_container.dart (+26 -16)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/checklist_cell/checklist_cell.dart (+28 -47)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/checklist_cell/checklist_cell_editor.dart (+2 -2)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/checklist_cell/checklist_progress_bar.dart (+8 -8)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart (+30 -33)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/row/grid_row.dart (+2 -2)

📄 Description

As a result of a previous change to fix cell accessories on URL cells, the 'open as a page' accessory for primary field cells no longer appear when hovering over the row, add it back!
ChangeNotifierProvider doesn't recreate the notifier when CellContainer is rebuilt, which causes the bug. Therefore, make the notifier also rebuild with CellContainer.
remove unnecessary extra Stack and Inkwell widgets used to detect mouse presses in select option and checklist cells by porting to GridCellState.

resolves #1543

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1735 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 1/23/2023 **Status:** ✅ Merged **Merged:** 1/27/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `grid-focus-accessory-border` --- ### 📝 Commits (6) - [`5b897f6`](https://github.com/AppFlowy-IO/AppFlowy/commit/5b897f605c36163bd867aa854cf79fadcb9796f7) chore: improve primary cell accessory behavior - [`87ef97f`](https://github.com/AppFlowy-IO/AppFlowy/commit/87ef97f2a6d957a9b0f5314f4c1e02cb8f905bcf) fix: focus border disappearing - [`5197036`](https://github.com/AppFlowy-IO/AppFlowy/commit/5197036169c7f3371fb6c7ecf8866aee9501179a) chore: port to GridCellState - [`b6b9707`](https://github.com/AppFlowy-IO/AppFlowy/commit/b6b97073929c430ce857a4a429795607360a0941) chore: fix typo - [`0f2b2f4`](https://github.com/AppFlowy-IO/AppFlowy/commit/0f2b2f44e5ab914a2983003d8f3ad1cecb0ca4e4) chore: connect popover controller - [`2d65875`](https://github.com/AppFlowy-IO/AppFlowy/commit/2d65875aba54d4a11d3d3362f2a9320b18b2c5bb) chore: final ### 📊 Changes **8 files changed** (+109 additions, -122 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/board/presentation/card/board_checklist_cell.dart` (+5 -2) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_accessory.dart` (+8 -12) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_container.dart` (+26 -16) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/checklist_cell/checklist_cell.dart` (+28 -47) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/checklist_cell/checklist_cell_editor.dart` (+2 -2) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/checklist_cell/checklist_progress_bar.dart` (+8 -8) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart` (+30 -33) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/row/grid_row.dart` (+2 -2) </details> ### 📄 Description - As a result of a previous change to fix cell accessories on URL cells, the 'open as a page' accessory for primary field cells no longer appear when hovering over the row, add it back! - `ChangeNotifierProvider` doesn't recreate the notifier when `CellContainer` is rebuilt, which causes the bug. Therefore, make the notifier also rebuild with `CellContainer`. - remove unnecessary extra `Stack` and `Inkwell` widgets used to detect mouse presses in select option and checklist cells by porting to `GridCellState`. resolves #1543 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>