[PR #1747] [MERGED] feat: on enter exit editing property field #1295 #4930

New issue

Closed

opened 2026-03-23 22:16:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1747
Author: @zoli
Created: 1/27/2023
Status: ✅ Merged
Merged: 2/2/2023
Merged by: @LucasXu0

Base: main ← Head: feat/close-field-on-enter-iss1295

📝 Commits (5)

a2159de feat: on enter exit editing property field #1295
8d30ea9 chore: use FlowyTextField instead of RoundedInputField
6385ffa fix: make all text field border radius 10, added errorBorder
903bdef fix: put cursor position at end of text field
eac116d chore: make errorText optional on FlowyTextField

📊 Changes

3 files changed (+32 additions, -24 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart (+11 -23)
📝 frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/text_field.dart (+18 -1)
📝 frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart (+3 -0)

📄 Description

Introduces onFieldSubmitted on RoundedInputField type that will get used as TextFormField property.

Closes #1295.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1747 **Author:** [@zoli](https://github.com/zoli) **Created:** 1/27/2023 **Status:** ✅ Merged **Merged:** 2/2/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/close-field-on-enter-iss1295` --- ### 📝 Commits (5) - [`a2159de`](https://github.com/AppFlowy-IO/AppFlowy/commit/a2159dee0f6f0d50ba925f34ceedbba6716cfc52) feat: on enter exit editing property field #1295 - [`8d30ea9`](https://github.com/AppFlowy-IO/AppFlowy/commit/8d30ea990f154a38ba655ab04fd48e24c62e27b5) chore: use FlowyTextField instead of RoundedInputField - [`6385ffa`](https://github.com/AppFlowy-IO/AppFlowy/commit/6385ffa7432ad1dfca559927ca318db190563858) fix: make all text field border radius 10, added errorBorder - [`903bdef`](https://github.com/AppFlowy-IO/AppFlowy/commit/903bdef7b9f0553e66e608d0ced39a2132f11c5c) fix: put cursor position at end of text field - [`eac116d`](https://github.com/AppFlowy-IO/AppFlowy/commit/eac116db8d0dc2320508c0df1ae5cc6ff7587e8f) chore: make errorText optional on FlowyTextField ### 📊 Changes **3 files changed** (+32 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart` (+11 -23) 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/text_field.dart` (+18 -1) 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart` (+3 -0) </details> ### 📄 Description Introduces `onFieldSubmitted` on `RoundedInputField` type that will get used as `TextFormField` property. Closes #1295. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>