[PR #1755] [MERGED] fix: empty url group bug #4931

New issue

Closed

opened 2026-03-23 22:16:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1755
Author: @zoli
Created: 1/29/2023
Status: ✅ Merged
Merged: 2/13/2023
Merged by: @annieappflowy

Base: main ← Head: fix/group_by_url_no_status_group

📝 Commits (4)

4541410 fix: empty url group bug
e622d72 fix: move empty group check to insert_url_cell
a260b0b chore: cargo fmt
84e56dd chore: Merge branch 'main' into fix/group_by_url_no_status_group

📊 Changes

2 files changed (+12 additions, -0 deletions)

View changed files

📝 frontend/rust-lib/flowy-database/src/services/cell/cell_operation.rs (+11 -0)
📝 frontend/rust-lib/flowy-database/src/services/group/controller_impls/url_controller.rs (+1 -0)

📄 Description

Moving a row to empty url (no status) group would change the row's url to the group id which is not empty, its a random string. fixed it with puting a check to fill the url with the empty string when the group id is equal to empty url group id.

I'm not sure this is a good way to fix it though.

Continuing from https://github.com/AppFlowy-IO/AppFlowy/pull/1687 and #1175.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1755 **Author:** [@zoli](https://github.com/zoli) **Created:** 1/29/2023 **Status:** ✅ Merged **Merged:** 2/13/2023 **Merged by:** [@annieappflowy](https://github.com/annieappflowy) **Base:** `main` ← **Head:** `fix/group_by_url_no_status_group` --- ### 📝 Commits (4) - [`4541410`](https://github.com/AppFlowy-IO/AppFlowy/commit/45414109f19708b7970488e2016b30491f109f4f) fix: empty url group bug - [`e622d72`](https://github.com/AppFlowy-IO/AppFlowy/commit/e622d729a4d6d9692678c6a56c4447bacdeba490) fix: move empty group check to `insert_url_cell` - [`a260b0b`](https://github.com/AppFlowy-IO/AppFlowy/commit/a260b0b7da5236efaa390758076faf993375e3b5) chore: cargo fmt - [`84e56dd`](https://github.com/AppFlowy-IO/AppFlowy/commit/84e56dd13a29ce5360cf69bfc459712f3db314ea) chore: Merge branch 'main' into fix/group_by_url_no_status_group ### 📊 Changes **2 files changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-database/src/services/cell/cell_operation.rs` (+11 -0) 📝 `frontend/rust-lib/flowy-database/src/services/group/controller_impls/url_controller.rs` (+1 -0) </details> ### 📄 Description Moving a row to empty url (no status) group would change the row's url to the group id which is not empty, its a random string. fixed it with puting a check to fill the url with the empty string when the group id is equal to empty url group id. I'm not sure this is a good way to fix it though. Continuing from https://github.com/AppFlowy-IO/AppFlowy/pull/1687 and #1175. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>