[PR #1787] [MERGED] Fix/grid group #4942

New issue

Closed

opened 2026-03-23 22:16:30 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1787
Author: @appflowy
Created: 2/2/2023
Status: ✅ Merged
Merged: 2/2/2023
Merged by: @appflowy

Base: main ← Head: fix/grid_group

📝 Commits (7)

c36cb9d ci: config rust log
ba16fa7 chore: rename flowy-sdk to appflowy-core
95fb00c fix: create group after editing the url
4a16467 fix: start listen on new group
2238e19 chore: add tests
1ec7108 refactor: mock data
d8d2afc ci: update command

📊 Changes

73 files changed (+1570 additions, -1901 deletions)

View changed files

📝 .github/workflows/rust_ci.yaml (+1 -1)
📝 frontend/.vscode/launch.json (+1 -1)
📝 frontend/.vscode/tasks.json (+1 -1)
📝 frontend/Makefile.toml (+1 -1)
📝 frontend/app_flowy/lib/plugins/board/application/board_bloc.dart (+43 -33)
📝 frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart (+3 -3)
📝 frontend/app_flowy/lib/plugins/board/application/board_listener.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/grid/application/cell/cell_service/cell_controller.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/grid/application/cell/url_cell_editor_bloc.dart (+9 -4)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/cell_editor.dart (+21 -8)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/url_cell.dart (+2 -0)
📝 frontend/appflowy_tauri/src-tauri/src/init.rs (+4 -4)
📝 frontend/appflowy_tauri/src-tauri/src/request.rs (+2 -2)
📝 frontend/rust-lib/dart-ffi/src/lib.rs (+5 -5)
📝 frontend/rust-lib/flowy-core/src/lib.rs (+19 -19)
📝 frontend/rust-lib/flowy-database/src/entities/group_entities/group_changeset.rs (+2 -2)
📝 frontend/rust-lib/flowy-database/src/services/cell/cell_operation.rs (+42 -4)
📝 frontend/rust-lib/flowy-database/src/services/field/type_options/type_option_cell.rs (+1 -1)
📝 frontend/rust-lib/flowy-database/src/services/field/type_options/url_type_option/url_type_option_entities.rs (+9 -0)
📝 frontend/rust-lib/flowy-database/src/services/grid_editor.rs (+10 -8)

...and 53 more files

📄 Description

fix #1733

delete URL group if there are no rows in that group
create new group if the URL of the cell was changed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1787 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 2/2/2023 **Status:** ✅ Merged **Merged:** 2/2/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/grid_group` --- ### 📝 Commits (7) - [`c36cb9d`](https://github.com/AppFlowy-IO/AppFlowy/commit/c36cb9d196721394665d299d9e31f37868c327f4) ci: config rust log - [`ba16fa7`](https://github.com/AppFlowy-IO/AppFlowy/commit/ba16fa78b737ea9eeeda11521a42d56770d72d4d) chore: rename flowy-sdk to appflowy-core - [`95fb00c`](https://github.com/AppFlowy-IO/AppFlowy/commit/95fb00c554e58371838820f7d0272978c5a4bcc0) fix: create group after editing the url - [`4a16467`](https://github.com/AppFlowy-IO/AppFlowy/commit/4a164670943b1d440b49d7ae8be698e4e72e4f39) fix: start listen on new group - [`2238e19`](https://github.com/AppFlowy-IO/AppFlowy/commit/2238e197d702ebb6effd34f844223849c6ca28c5) chore: add tests - [`1ec7108`](https://github.com/AppFlowy-IO/AppFlowy/commit/1ec7108aa2e2ddbf2c4ee097362b7435fa701502) refactor: mock data - [`d8d2afc`](https://github.com/AppFlowy-IO/AppFlowy/commit/d8d2afcab71f14d41b3a72ca743fe47cabd14d88) ci: update command ### 📊 Changes **73 files changed** (+1570 additions, -1901 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/rust_ci.yaml` (+1 -1) 📝 `frontend/.vscode/launch.json` (+1 -1) 📝 `frontend/.vscode/tasks.json` (+1 -1) 📝 `frontend/Makefile.toml` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/board/application/board_bloc.dart` (+43 -33) 📝 `frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart` (+3 -3) 📝 `frontend/app_flowy/lib/plugins/board/application/board_listener.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/grid/application/cell/cell_service/cell_controller.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/grid/application/cell/url_cell_editor_bloc.dart` (+9 -4) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/cell_editor.dart` (+21 -8) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/url_cell.dart` (+2 -0) 📝 `frontend/appflowy_tauri/src-tauri/src/init.rs` (+4 -4) 📝 `frontend/appflowy_tauri/src-tauri/src/request.rs` (+2 -2) 📝 `frontend/rust-lib/dart-ffi/src/lib.rs` (+5 -5) 📝 `frontend/rust-lib/flowy-core/src/lib.rs` (+19 -19) 📝 `frontend/rust-lib/flowy-database/src/entities/group_entities/group_changeset.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-database/src/services/cell/cell_operation.rs` (+42 -4) 📝 `frontend/rust-lib/flowy-database/src/services/field/type_options/type_option_cell.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database/src/services/field/type_options/url_type_option/url_type_option_entities.rs` (+9 -0) 📝 `frontend/rust-lib/flowy-database/src/services/grid_editor.rs` (+10 -8) _...and 53 more files_ </details> ### 📄 Description fix #1733 1. delete URL group if there are no rows in that group 2. create new group if the URL of the cell was changed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>