[PR #1789] [MERGED] fix: #1290 [Bug] 300ms delay on buttons in titlebar #4943

Closed
opened 2026-03-23 22:16:30 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1789
Author: @LucasXu0
Created: 2/3/2023
Status: Merged
Merged: 2/5/2023
Merged by: @LucasXu0

Base: mainHead: fix_1290


📝 Commits (1)

  • be2ddb1 fix: #1290 [Bug] 300ms delay on buttons in titlebar

📊 Changes

2 files changed (+38 additions, -1 deletions)

View changed files

📝 frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart (+7 -1)
frontend/app_flowy/packages/flowy_infra_ui/lib/widget/ignore_parent_gesture.dart (+31 -0)

📄 Description

Just a workaround to prevent the MoveWindowDetector from accepting the events.

Reference


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1789 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 2/3/2023 **Status:** ✅ Merged **Merged:** 2/5/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_1290` --- ### 📝 Commits (1) - [`be2ddb1`](https://github.com/AppFlowy-IO/AppFlowy/commit/be2ddb1d897994836fd9fd0e17793d68578645a7) fix: #1290 [Bug] 300ms delay on buttons in titlebar ### 📊 Changes **2 files changed** (+38 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/button.dart` (+7 -1) ➕ `frontend/app_flowy/packages/flowy_infra_ui/lib/widget/ignore_parent_gesture.dart` (+31 -0) </details> ### 📄 Description Just a workaround to prevent the `MoveWindowDetector` from accepting the events. Reference * https://docs.flutter.dev/development/ui/advanced/gestures#gesture-disambiguation * https://github.com/flutter/flutter/issues/67255 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:16:30 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#4943
No description provided.