[PR #1842] [MERGED] Refactor app window logic #4970

New issue

Closed

opened 2026-03-23 22:16:38 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1842
Author: @Merrit
Created: 2/10/2023
Status: ✅ Merged
Merged: 2/11/2023
Merged by: @appflowy

Base: main ← Head: refactor_appwindow

📝 Commits (4)

6f945ca feat: add TargetPlatform isDesktop helper
26760dc refactor: move window logic to separate class
ebca625 fix: isDesktop doc comment
58bc39d fix: set window title

📊 Changes

5 files changed (+52 additions, -13 deletions)

View changed files

➕ frontend/app_flowy/lib/core/helpers/helpers.dart (+1 -0)
➕ frontend/app_flowy/lib/core/helpers/target_platform.dart (+11 -0)
📝 frontend/app_flowy/lib/main.dart (+2 -13)
➕ frontend/app_flowy/lib/window/app_window.dart (+37 -0)
➕ frontend/app_flowy/lib/window/window.dart (+1 -0)

📄 Description

This is much cleaner and better encapsulated. Sets up an area for further window management in the future.

Does not try to initialize on mobile or web, which would crash.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1842 **Author:** [@Merrit](https://github.com/Merrit) **Created:** 2/10/2023 **Status:** ✅ Merged **Merged:** 2/11/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `refactor_appwindow` --- ### 📝 Commits (4) - [`6f945ca`](https://github.com/AppFlowy-IO/AppFlowy/commit/6f945ca22413bd064ebef2da5389703ddcbc8474) feat: add TargetPlatform `isDesktop` helper - [`26760dc`](https://github.com/AppFlowy-IO/AppFlowy/commit/26760dcd3448ab9e92ae478a5b379aa58f87c332) refactor: move window logic to separate class - [`ebca625`](https://github.com/AppFlowy-IO/AppFlowy/commit/ebca625858e562237fd44e8330733dcf9a9701ef) fix: isDesktop doc comment - [`58bc39d`](https://github.com/AppFlowy-IO/AppFlowy/commit/58bc39d6cedde0bb8e95e73d7feeebbf4e89726b) fix: set window title ### 📊 Changes **5 files changed** (+52 additions, -13 deletions) <details> <summary>View changed files</summary> ➕ `frontend/app_flowy/lib/core/helpers/helpers.dart` (+1 -0) ➕ `frontend/app_flowy/lib/core/helpers/target_platform.dart` (+11 -0) 📝 `frontend/app_flowy/lib/main.dart` (+2 -13) ➕ `frontend/app_flowy/lib/window/app_window.dart` (+37 -0) ➕ `frontend/app_flowy/lib/window/window.dart` (+1 -0) </details> ### 📄 Description This is much cleaner and better encapsulated. Sets up an area for further window management in the future. Does not try to initialize on mobile or web, which would crash. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>