[GH-ISSUE #1290 ] [Bug] 300ms delay on buttons in titlebar #499

Author

Owner

@annieappflowy commented on GitHub (Oct 17, 2022):

@cbenhagen @ChiragKr04 thanks. I can reproduce on macOS. I agree that it reacts slower than it should be.

@annieappflowy commented on GitHub (Oct 17, 2022): @cbenhagen @ChiragKr04 thanks. I can reproduce on macOS. I agree that it reacts slower than it should be.

mirror commented

Author

Owner

@annieappflowy commented on GitHub (Oct 17, 2022):

@LucasXu0 , can you evaluate if this is a good issue for Hacktoberfest?

@annieappflowy commented on GitHub (Oct 17, 2022): @LucasXu0 , can you evaluate if this is a good issue for Hacktoberfest?

mirror commented

Author

Owner

@LucasXu0 commented on GitHub (Oct 17, 2022):

OK. The main reason for this issue is that the two gestures are in conflict. I think using Listener instead of GestureDetector is a way to fix this issue. Maybe there is a better way, but I don't find yet.

@LucasXu0 commented on GitHub (Oct 17, 2022): OK. The main reason for this issue is that the two gestures are in conflict. I think using `Listener` instead of `GestureDetector` is a way to fix this issue. Maybe there is a better way, but I don't find yet.

mirror commented

Author

Owner

@LucasXu0 commented on GitHub (Oct 17, 2022):

class RoundedTextButton extends StatelessWidget {
  // ...
  @override
  Widget build(BuildContext context) {
    // ...
        child: SizedBox.expand(
          child: Listener(
            onPointerDown: (event) => onPressed?.call(),
            onPointerSignal: (event) {
              // do nothing, just to prevent to call the parent's actions
            },
            child: Center(
              child: Text(
                title ?? '',
                style: TextStyle(color: textColor, fontSize: fontSize),
              ),
            ),
          ),
          // TextButton(
          //   onPressed: onPressed,
          //   child: Text(
          //     title ?? '',
          //     style: TextStyle(color: textColor, fontSize: fontSize),
          //   ),
          // ),
   // ...
  }
}

@LucasXu0 commented on GitHub (Oct 17, 2022): ``` class RoundedTextButton extends StatelessWidget { // ... @override Widget build(BuildContext context) { // ... child: SizedBox.expand( child: Listener( onPointerDown: (event) => onPressed?.call(), onPointerSignal: (event) { // do nothing, just to prevent to call the parent's actions }, child: Center( child: Text( title ?? '', style: TextStyle(color: textColor, fontSize: fontSize), ), ), ), // TextButton( // onPressed: onPressed, // child: Text( // title ?? '', // style: TextStyle(color: textColor, fontSize: fontSize), // ), // ), // ... } } ```

mirror commented

Author

Owner

@AdiAr11 commented on GitHub (Oct 19, 2022):

Hi, I've successfully built the app for mac. @LucasXu0 could you please guide me a little? Is the issue because of GestureDetector in frameless_window.dart which you shared?

@AdiAr11 commented on GitHub (Oct 19, 2022): Hi, I've successfully built the app for mac. @LucasXu0 could you please guide me a little? Is the issue because of GestureDetector in frameless_window.dart which you shared?

mirror commented

Author

Owner

@AdiAr11 commented on GitHub (Oct 19, 2022):

class RoundedTextButton extends StatelessWidget {
// ...
@override
Widget build(BuildContext context) {
// ...
child: SizedBox.expand(
child: Listener(
onPointerDown: (event) => onPressed?.call(),
onPointerSignal: (event) {
// do nothing, just to prevent to call the parent's actions
},
child: Center(
child: Text(
title ?? '',
style: TextStyle(color: textColor, fontSize: fontSize),
),
),
),
// TextButton(
// onPressed: onPressed,
// child: Text(
// title ?? '',
// style: TextStyle(color: textColor, fontSize: fontSize),
// ),
// ),
// ...
}
}

What should I look for in this file?

@AdiAr11 commented on GitHub (Oct 19, 2022): > class RoundedTextButton extends StatelessWidget { > // ... > @override > Widget build(BuildContext context) { > // ... > child: SizedBox.expand( > child: Listener( > onPointerDown: (event) => onPressed?.call(), > onPointerSignal: (event) { > // do nothing, just to prevent to call the parent's actions > }, > child: Center( > child: Text( > title ?? '', > style: TextStyle(color: textColor, fontSize: fontSize), > ), > ), > ), > // TextButton( > // onPressed: onPressed, > // child: Text( > // title ?? '', > // style: TextStyle(color: textColor, fontSize: fontSize), > // ), > // ), > // ... > } > } What should I look for in this file?

mirror commented

Author

Owner

@LucasXu0 commented on GitHub (Oct 20, 2022):

Hi, @AdiAr11. The file locates in frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_button.dart. The share button has to delay its response because of the GestureDetector in frameless_window.dart.

@LucasXu0 commented on GitHub (Oct 20, 2022): Hi, @AdiAr11. The file locates in `frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_button.dart`. The share button has to delay its response because of the `GestureDetector` in `frameless_window.dart`.

mirror commented

Author

Owner

@AdiAr11 commented on GitHub (Oct 20, 2022):

Oh, Okay. I'll try to fix this. Thank you!

@AdiAr11 commented on GitHub (Oct 20, 2022): Oh, Okay. I'll try to fix this. Thank you!

mirror commented

Author

Owner

@cbenhagen commented on GitHub (Oct 20, 2022):

You might also want to wrap your Listener in GestureDetector with an empty onDoubleTap handler so that double clicking your new button will not maximize the window.

@cbenhagen commented on GitHub (Oct 20, 2022): You might also want to wrap your `Listener` in `GestureDetector` with an empty `onDoubleTap` handler so that double clicking your new button will not maximize the window.

mirror commented

Author

Owner

@AdiAr11 commented on GitHub (Oct 22, 2022):

@cbenhagen Sure, thank you!

@AdiAr11 commented on GitHub (Oct 22, 2022): @cbenhagen Sure, thank you!

mirror commented

Author

Owner

@annieappflowy commented on GitHub (Oct 28, 2022):

@AdiAr11 , any progress update on this issue? Let us know if you need help. Thanks!

@annieappflowy commented on GitHub (Oct 28, 2022): @AdiAr11 , any progress update on this issue? Let us know if you need help. Thanks!

mirror commented

Author

Owner

@AdiAr11 commented on GitHub (Oct 28, 2022):

@annieappflowy sorry, im out of town. I'll be back in 2 days.
I had some doubts though, I'll ask them when i get back.

@AdiAr11 commented on GitHub (Oct 28, 2022): @annieappflowy sorry, im out of town. I'll be back in 2 days. I had some doubts though, I'll ask them when i get back.

mirror commented

Author

Owner

@annieappflowy commented on GitHub (Nov 9, 2022):

Any update / progress on this issue? @AdiAr11

@annieappflowy commented on GitHub (Nov 9, 2022): Any update / progress on this issue? @AdiAr11

mirror commented

Author

Owner

@AdiAr11 commented on GitHub (Nov 12, 2022):

Yes, sorry for late reply. I tried the above approach and it was still the same. I researched and I saw that there is a delay because of a potential second tap.

@AdiAr11 commented on GitHub (Nov 12, 2022): Yes, sorry for late reply. I tried the above approach and it was still the same. I researched and I saw that there is a delay because of a potential second tap.

mirror commented