mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-24 21:00:19 +00:00
[GH-ISSUE #1279] [Bug]: huge app size due to duplicate (non-symlinked) framework files #500
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#500
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @eugenesvk on GitHub (Oct 14, 2022).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1279
Originally assigned to: @LucasXu0 on GitHub.
Bug Description
The macOS app is ~180Mb, which is surprising for a non-Electron app.
I've noticed that there are multiple duplicate identical files in a structure that is usually one regular file with multiple symlinks, e.g.
Same thing with the
FlutterMacOS.frameworkHow to Reproduce
Download the zip release file from this repo
Unzip it
View the content of the
AppFlowy.appapp (see the paths above)Expected Behavior
Only a single version fo the framework should be present, everything else should be a symlink
Operating System
macOS 10.15
AppFlowy Version(s)
0.0.5.3 (1)
Screenshots
No response
Additional Context
Might this be due to some wrong zip/unzip options that don't preserve symlinks? Or was this issue part of some build process error?
(manually replacing 2×3 files with 2 files and 2×2 symlinks had no effect on the app, except for reducing its size to <80m)
@LucasXu0 commented on GitHub (Oct 14, 2022):
It's odd. The size of the macOS app is about 140MB when I execute the
flutter build macos --releaseon my local desktop. But the size of the macOS app is about 180+MB when it is built from CI.I will try to fix it before releasing the next version.
@LucasXu0 commented on GitHub (Oct 15, 2022):
Hi, @eugenesvk. The
symlinkparameter is not passed when compressing. I updated the build script and verified it on my personal repo. Thank you so much for the suggestion.https://github.com/LucasXu0/AppFlowy/releases/tag/1000.0.0
@LucasXu0 commented on GitHub (Oct 15, 2022):
The size of the macOS package has dropped by about 40MB.
Before

After

@eugenesvk commented on GitHub (Oct 15, 2022):
Can confirm that your fork has symlinks and those two huge app/fluttermacos framework files aren't duplicate any more, thanks!
Still looks a bit large for a native note app (100m=50m two frameworks + 50m the app binary itself), but that's a separate issue
@LucasXu0 commented on GitHub (Oct 17, 2022):
The size of a new-created flutter app without any features is about 46M. So I think it is acceptable for the 100M now.