[PR #1900] [MERGED] revert(appflowy_editor): revert code for relicense #5003

New issue

Closed

opened 2026-03-23 22:16:46 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1900
Author: @hyj1204
Created: 2/28/2023
Status: ✅ Merged
Merged: 3/2/2023
Merged by: @LucasXu0

Base: feature/editor_relicense ← Head: revert_for_relicense

📝 Commits (7)

b2b5729 revert:"fix: remove keyword when click selection menu item"
971e88f revert(appflowy_editor):revert "feat: double asterisks/underscores to bold text"
7974b7a revert(appflowy_editor):revert "fix: workaround infinity formatting"
59e58bb chore(appflow_editor):update test variable after reverting
5086458 chore(appflowy_editor): comment out the test for reverting
cb04eea chore(appflowy_editor): update variable type after reverting
a1e740a chore(appflowy_editor): remove unused import after reverting

📊 Changes

20 files changed (+111 additions, -575 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/board/board_menu_item.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/grid/grid_menu_item.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/horizontal_rule_node_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor/example/lib/plugin/AI/auto_completion.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor/example/lib/plugin/AI/continue_to_write.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/core/legacy/built_in_attribute_keys.dart (+0 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_item_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart (+9 -9)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_widget.dart (+14 -38)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/markdown_syntax_to_styled_text.dart (+0 -129)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart (+0 -10)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/infra/test_raw_key_event.dart (+0 -6)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/render/rich_text/checkbox_text_test.dart (+48 -49)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart (+29 -45)
➖ frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/markdown_syntax_to_styled_text_handler_test.dart (+0 -277)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/slash_handler_test.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor_plugins/lib/src/code_block/code_block_shortcut_event.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor_plugins/lib/src/divider/divider_shortcut_event.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor_plugins/lib/src/emoji_picker/emoji_menu_item.dart (+1 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor_plugins/lib/src/math_ equation/math_equation_node_widget.dart (+1 -1)

📄 Description

This PR aims to revert the code to its previous state in order to prepare for relicensing. It is related to #1881.

Reverts commit 5782dec45cf2dfb4628fe6f153c52109c9ce5a5b(fix: remove keyword when click selection menu item)
Reverts commit c0964fad5d3b64c4d7b797ecfbfc6a9cfc2f9174(feat: double asterisks/underscores to bold text)
Reverts commit 6a902a2b218afcf0adc0e9cbf0a52864ecb93118(fix: workaround infinity formatting):
For reverting this commit, I only deleted 'defaultFormating' String in built_in_attribute_keys.dart, The rest of this commit is in the 'appflowy' folder under 'frontend'. This folder has been previously deleted.
Reverts commit a8cb58cb4a696543f0296cbd6ca17cc980c8e18b(fix: address a minor isssue when there is content after last asterisk/underscore):
The code in this commit is in the 'appflowy' folder under 'frontend'. This folder has been previously deleted, so there is nothing need to do for reverting this commit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1900 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 2/28/2023 **Status:** ✅ Merged **Merged:** 3/2/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `feature/editor_relicense` ← **Head:** `revert_for_relicense` --- ### 📝 Commits (7) - [`b2b5729`](https://github.com/AppFlowy-IO/AppFlowy/commit/b2b5729f94405a6858675e3d5e70e2f41b81841e) revert:"fix: remove keyword when click selection menu item" - [`971e88f`](https://github.com/AppFlowy-IO/AppFlowy/commit/971e88fcf6055839d0e1f19e45f3feafa3c16c00) revert(appflowy_editor):revert "feat: double asterisks/underscores to bold text" - [`7974b7a`](https://github.com/AppFlowy-IO/AppFlowy/commit/7974b7a5d0cee089167b837700cdc9e4b73b0266) revert(appflowy_editor):revert "fix: workaround infinity formatting" - [`59e58bb`](https://github.com/AppFlowy-IO/AppFlowy/commit/59e58bb7dcd8e42f9312636dd5f0706e359a947c) chore(appflow_editor):update test variable after reverting - [`5086458`](https://github.com/AppFlowy-IO/AppFlowy/commit/5086458b1cd0b1a3b1055e44d5d37848d16b3c4c) chore(appflowy_editor): comment out the test for reverting - [`cb04eea`](https://github.com/AppFlowy-IO/AppFlowy/commit/cb04eeafb844756428f1bb60d64ae63dbebd3ce4) chore(appflowy_editor): update variable type after reverting - [`a1e740a`](https://github.com/AppFlowy-IO/AppFlowy/commit/a1e740a6e7fe1c4ae73769f97c3f5497990adb31) chore(appflowy_editor): remove unused import after reverting ### 📊 Changes **20 files changed** (+111 additions, -575 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/board/board_menu_item.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/grid/grid_menu_item.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/horizontal_rule_node_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/example/lib/plugin/AI/auto_completion.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/example/lib/plugin/AI/continue_to_write.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/core/legacy/built_in_attribute_keys.dart` (+0 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_item_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart` (+9 -9) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_widget.dart` (+14 -38) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/markdown_syntax_to_styled_text.dart` (+0 -129) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart` (+0 -10) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/infra/test_raw_key_event.dart` (+0 -6) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/render/rich_text/checkbox_text_test.dart` (+48 -49) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart` (+29 -45) ➖ `frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/markdown_syntax_to_styled_text_handler_test.dart` (+0 -277) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/slash_handler_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor_plugins/lib/src/code_block/code_block_shortcut_event.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor_plugins/lib/src/divider/divider_shortcut_event.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor_plugins/lib/src/emoji_picker/emoji_menu_item.dart` (+1 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor_plugins/lib/src/math_ equation/math_equation_node_widget.dart` (+1 -1) </details> ### 📄 Description This PR aims to revert the code to its previous state in order to prepare for relicensing. It is related to #1881. - [x] Reverts commit 5782dec45cf2dfb4628fe6f153c52109c9ce5a5b(fix: remove keyword when click selection menu item) - [x] Reverts commit c0964fad5d3b64c4d7b797ecfbfc6a9cfc2f9174(feat: double asterisks/underscores to bold text) - [x] Reverts commit 6a902a2b218afcf0adc0e9cbf0a52864ecb93118(fix: workaround infinity formatting): For reverting this commit, I only deleted 'defaultFormating' String in `built_in_attribute_keys.dart`, The rest of this commit is in the 'appflowy' folder under 'frontend'. This folder has been previously deleted. - [x] Reverts commit a8cb58cb4a696543f0296cbd6ca17cc980c8e18b(fix: address a minor isssue when there is content after last asterisk/underscore): The code in this commit is in the 'appflowy' folder under 'frontend'. This folder has been previously deleted, so there is nothing need to do for reverting this commit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>