[PR #1935] [MERGED] feat(appflowy_editor): double asterisk to bold text and remove slash after clicking selection menu item #5027

Closed
opened 2026-03-23 22:16:53 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1935
Author: @hyj1204
Created: 3/7/2023
Status: Merged
Merged: 3/8/2023
Merged by: @LucasXu0

Base: feature/editor_relicenseHead: feature/editor_relicense


📝 Commits (4)

  • c07d5da feat(appflowy_editor): double asterisk to bold text
  • 097b675 test(appflowy_editor): test double asterisk to bold text
  • 11e1551 fix(appflowy_editor): delete slash after a selection menu item is selected
  • 816e491 test(appflowy_editor): test selection menu widget after clicking

📊 Changes

6 files changed (+221 additions, -13 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_widget.dart (+39 -12)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/markdown_syntax_to_styled_text.dart (+56 -0)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart (+5 -0)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/infra/test_raw_key_event.dart (+3 -0)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart (+24 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/markdown_syntax_to_styled_text_test.dart (+94 -0)

📄 Description

Add the following two features which were removed due to license reason

  1. double asterisk to bold text
  2. remove the slash '/' after clicking the selection menu item

Related to #1900
Resolves #1881


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1935 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 3/7/2023 **Status:** ✅ Merged **Merged:** 3/8/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `feature/editor_relicense` ← **Head:** `feature/editor_relicense` --- ### 📝 Commits (4) - [`c07d5da`](https://github.com/AppFlowy-IO/AppFlowy/commit/c07d5da428ec1f7f02cdb1ced2345ecf37d75eec) feat(appflowy_editor): double asterisk to bold text - [`097b675`](https://github.com/AppFlowy-IO/AppFlowy/commit/097b6752d0f340433cc80fd796671eec7299f9c9) test(appflowy_editor): test double asterisk to bold text - [`11e1551`](https://github.com/AppFlowy-IO/AppFlowy/commit/11e1551a55e1c254478851b5378b968830a8949b) fix(appflowy_editor): delete slash after a selection menu item is selected - [`816e491`](https://github.com/AppFlowy-IO/AppFlowy/commit/816e49162579753232b93dcd0b7290e260d1c07b) test(appflowy_editor): test selection menu widget after clicking ### 📊 Changes **6 files changed** (+221 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_widget.dart` (+39 -12) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/markdown_syntax_to_styled_text.dart` (+56 -0) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart` (+5 -0) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/infra/test_raw_key_event.dart` (+3 -0) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart` (+24 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/markdown_syntax_to_styled_text_test.dart` (+94 -0) </details> ### 📄 Description Add the following two features which were removed due to license reason 1. double asterisk to bold text 2. remove the slash '/' after clicking the selection menu item Related to #1900 Resolves #1881 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:16:53 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5027
No description provided.