[PR #1946] [MERGED] fix: #1778 #5036

Closed
opened 2026-03-23 22:16:55 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1946
Author: @LucasXu0
Created: 3/9/2023
Status: Merged
Merged: 3/9/2023
Merged by: @LucasXu0

Base: mainHead: feature/improve_toolbar


📝 Commits (2)

  • 5fe9123 fix: [FR] The text formatting toolbar should appear after the selection #1778
  • 67d30ca chore: format code

📊 Changes

5 files changed (+75 additions, -10 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/selection_service.dart (+44 -8)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/toolbar_service.dart (+10 -2)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/render/rich_text/toolbar_rich_text_test.dart (+12 -0)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/format_style_handler_test.dart (+1 -0)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/service/toolbar_service_test.dart (+8 -0)

📄 Description

Closes #1778


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1946 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 3/9/2023 **Status:** ✅ Merged **Merged:** 3/9/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feature/improve_toolbar` --- ### 📝 Commits (2) - [`5fe9123`](https://github.com/AppFlowy-IO/AppFlowy/commit/5fe9123b6b87437c85ffbe4c4eaaf495642ddf8a) fix: [FR] The text formatting toolbar should appear after the selection #1778 - [`67d30ca`](https://github.com/AppFlowy-IO/AppFlowy/commit/67d30ca494a485a5a381d17373e090485453b9ee) chore: format code ### 📊 Changes **5 files changed** (+75 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/selection_service.dart` (+44 -8) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/toolbar_service.dart` (+10 -2) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/render/rich_text/toolbar_rich_text_test.dart` (+12 -0) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/format_style_handler_test.dart` (+1 -0) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/service/toolbar_service_test.dart` (+8 -0) </details> ### 📄 Description Closes #1778 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:16:55 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5036
No description provided.