[PR #1986] [MERGED] fix: bug on node iterator with nested nodes #5050

New issue

Closed

opened 2026-03-23 22:16:59 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:16:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1986
Author: @zoli
Created: 3/13/2023
Status: ✅ Merged
Merged: 3/14/2023
Merged by: @LucasXu0

Base: main ← Head: fix/node-iterator

📝 Commits (1)

875c87e fix: bug on node iterator with nested nodes

📊 Changes

2 files changed (+36 additions, -16 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/core/document/node_iterator.dart (+12 -16)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/core/document/node_iterator_test.dart (+24 -0)

📄 Description

When we have more than two level nodes nested (as children) the node iterator misses the first parent, because it goes as deep as possible at first.

Faced this while working on Table.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1986 **Author:** [@zoli](https://github.com/zoli) **Created:** 3/13/2023 **Status:** ✅ Merged **Merged:** 3/14/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/node-iterator` --- ### 📝 Commits (1) - [`875c87e`](https://github.com/AppFlowy-IO/AppFlowy/commit/875c87e5c38d2a5b00192f85af2c6d10221ea458) fix: bug on node iterator with nested nodes ### 📊 Changes **2 files changed** (+36 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/core/document/node_iterator.dart` (+12 -16) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/core/document/node_iterator_test.dart` (+24 -0) </details> ### 📄 Description When we have more than two level nodes nested (as children) the node iterator misses the first parent, because it goes as deep as possible at first. Faced this while working on Table. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>