[PR #1987] [CLOSED] Feat(appflowy_flutter): dark mode/theme improvement(side bar theme improvement) #5052

New issue

Closed

opened 2026-03-23 22:17:00 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1987
Author: @hyj1204
Created: 3/13/2023
Status: ❌ Closed

Base: main ← Head: feat/side_bar_theme_improvement

📝 Commits (2)

767dc69 feat(appflowy_flutter): add AFSideBarThemeExtension with basic style
b50750a feat(appflowy_flutter): update MenuTrash by AFSideBarThemeExtension

📊 Changes

3 files changed (+139 additions, -4 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/trash/menu.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/workspace/application/appearance.dart (+6 -2)
➕ frontend/appflowy_flutter/lib/workspace/application/sidebar_theme_extension.dart (+125 -0)

📄 Description

This PR is the part of Dark mode improvement #1671
3/14 update:
I plan to

Create AFSideBarThemeExtension to handler all the cosmetic attribute within the side bar area(the right section of the app). It has two modes to apply depends current user theme mode.

Use the theme extension data in all widgets' cosmetic attributes
(TODO) To use the colors in FlowyColorScheme in the AFSideBarThemeExtension. In this way, all the colors will come form its own theme under current light/dark mode.
(TODO) Organize all the theme extension in different parts of the app.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1987 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 3/13/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/side_bar_theme_improvement` --- ### 📝 Commits (2) - [`767dc69`](https://github.com/AppFlowy-IO/AppFlowy/commit/767dc69c08701444f393823a16c8e3a1a881700c) feat(appflowy_flutter): add AFSideBarThemeExtension with basic style - [`b50750a`](https://github.com/AppFlowy-IO/AppFlowy/commit/b50750a1c2cab4e2f0a8f715479b9b7f303367c4) feat(appflowy_flutter): update MenuTrash by AFSideBarThemeExtension ### 📊 Changes **3 files changed** (+139 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/trash/menu.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/workspace/application/appearance.dart` (+6 -2) ➕ `frontend/appflowy_flutter/lib/workspace/application/sidebar_theme_extension.dart` (+125 -0) </details> ### 📄 Description This PR is the part of Dark mode improvement #1671 3/14 update: I plan to 1. Create `AFSideBarThemeExtension` to handler all the cosmetic attribute within the side bar area(the right section of the app). It has two modes to apply depends current user theme mode. <p float="left"> <img width="193" alt="image" src="https://user-images.githubusercontent.com/14248245/224850241-8749e91b-e002-4af9-9286-abdf2c377d78.png"> <img width="198" alt="image" src="https://user-images.githubusercontent.com/14248245/224850172-0ad784fc-97e8-4474-8cd8-7ce81f7b75ab.png"> </p> 2. Use the theme extension data in all widgets' cosmetic attributes <img width="542" alt="image" src="https://user-images.githubusercontent.com/14248245/224851315-76da4f62-2818-4d85-99b5-64866a166368.png"> 3. (TODO) To use the colors in `FlowyColorScheme` in the `AFSideBarThemeExtension`. In this way, all the colors will come form its own theme under current light/dark mode. 4. (TODO) Organize all the theme extension in different parts of the app. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>