[PR #2011] [CLOSED] fix: bug causing permanent CircularProgressIndicator when referenced board is deleted fixes #2001 #5068

New issue

Closed

opened 2026-03-23 22:17:04 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2011
Author: @sshdopey
Created: 3/17/2023
Status: ❌ Closed

Base: main ← Head: fix/referenced_board_deletion

📝 Commits (4)

b7b27e5 fix: reference board deletion fixed (#2001)
531124f fix: reference board deletion updated
281925c Merge branch 'AppFlowy-IO:main' into fix/referenced_board_deletion
c1b5089 chore: simplify return within else clause

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/base/built_in_page_widget.dart (+3 -0)

📄 Description

If you add a referenced board or grid to a document and delete the board, the document will have a permanent circular progress indicator.

This pull request fixes a bug where deleting a referenced board results in a permanent circular progress indicator on the page. The issue occurs because the app is not handling the case where the referenced board is deleted.

To fix this issue, I added a check for whether the referenced board is null. If it is null, I returned SizedBox.shrink() to remove the board from the page. Additionally, I added a check for if the FutureBuilder has an error, and returned SizedBox.shrink() in that case as well.

I tested this fix by creating a new board, referencing it on a page, deleting the board, closing and reopening the app, and checking that the circular progress indicator was no longer present.

Please review and merge this pull request.

Thank you!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2011 **Author:** [@sshdopey](https://github.com/sshdopey) **Created:** 3/17/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/referenced_board_deletion` --- ### 📝 Commits (4) - [`b7b27e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/b7b27e5b168558760bfbf5bd784e68e920be217e) fix: reference board deletion fixed (#2001) - [`531124f`](https://github.com/AppFlowy-IO/AppFlowy/commit/531124f7855d65f27cf6d320f412427377000506) fix: reference board deletion updated - [`281925c`](https://github.com/AppFlowy-IO/AppFlowy/commit/281925c0d2fb863dba5571f4c74e980eae06f388) Merge branch 'AppFlowy-IO:main' into fix/referenced_board_deletion - [`c1b5089`](https://github.com/AppFlowy-IO/AppFlowy/commit/c1b5089c2ed9f1e76bc7f6ebe304f4c2da7461d0) chore: simplify return within else clause ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/base/built_in_page_widget.dart` (+3 -0) </details> ### 📄 Description If you add a referenced board or grid to a document and delete the board, the document will have a permanent circular progress indicator. This pull request fixes a bug where deleting a referenced board results in a permanent circular progress indicator on the page. The issue occurs because the app is not handling the case where the referenced board is deleted. To fix this issue, I added a check for whether the referenced board is null. If it is null, I returned `SizedBox.shrink()` to remove the board from the page. Additionally, I added a check for if the `FutureBuilder` has an error, and returned `SizedBox.shrink()` in that case as well. I tested this fix by creating a new board, referencing it on a page, deleting the board, closing and reopening the app, and checking that the circular progress indicator was no longer present. Please review and merge this pull request. Thank you! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>