[PR #2035] [MERGED] fix: scrolling selection-menu when it goes out of bound, fixes #2019 #5074

New issue

Closed

opened 2026-03-23 22:17:06 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2035
Author: @Samiksha-Garg
Created: 3/20/2023
Status: ✅ Merged
Merged: 3/20/2023
Merged by: @LucasXu0

Base: main ← Head: selection-menu-scrollable

📝 Commits (2)

e889b08 fix: scrolling selection-menu when it goes out of bound
b7190ea refactor: added comma as per style guidelines

📊 Changes

1 file changed (+18 additions, -14 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart (+18 -14)

📄 Description

On small window sizes, the width of the slash menu becomes greater and the menu overflows the right boundary. The user was hence not able to access all the menu items.

This PR fixes this issue. Now Selection menu scrolls in case of overflow, otherwise it behaves as it used to originally.

The following video illustrates the change I have made :

https://user-images.githubusercontent.com/79906086/226300367-5ff771d5-fa8b-4474-b022-916beaa30b73.mov

fixes #2019

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2035 **Author:** [@Samiksha-Garg](https://github.com/Samiksha-Garg) **Created:** 3/20/2023 **Status:** ✅ Merged **Merged:** 3/20/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `selection-menu-scrollable` --- ### 📝 Commits (2) - [`e889b08`](https://github.com/AppFlowy-IO/AppFlowy/commit/e889b0826c308ea535793097268de1588a8762a5) fix: scrolling selection-menu when it goes out of bound - [`b7190ea`](https://github.com/AppFlowy-IO/AppFlowy/commit/b7190ea42568f78d554e983b1bf334c15808071c) refactor: added comma as per style guidelines ### 📊 Changes **1 file changed** (+18 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart` (+18 -14) </details> ### 📄 Description On small window sizes, the width of the slash menu becomes greater and the menu overflows the right boundary. The user was hence not able to access all the menu items. This PR fixes this issue. Now Selection menu scrolls in case of overflow, otherwise it behaves as it used to originally. The following video illustrates the change I have made : https://user-images.githubusercontent.com/79906086/226300367-5ff771d5-fa8b-4474-b022-916beaa30b73.mov fixes #2019 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>