[PR #2065] [MERGED] Feat: sync name on change #5081

New issue

Closed

opened 2026-03-23 22:17:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2065
Author: @sshdopey
Created: 3/21/2023
Status: ✅ Merged
Merged: 5/3/2023
Merged by: @LucasXu0

Base: main ← Head: feat/sync_name_on_change

📝 Commits (2)

d5801e6 feat: sync name on change (AppFlowy-IO#2033)
e962a62 feat: sync name on change (AppFlowy-IO#2033)

📊 Changes

1 file changed (+36 additions, -6 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_user_view.dart (+36 -6)

📄 Description

Description:

Screencast from 21-03-2023 09:15:59.webm

This pull request fixes issue #2033, which was related to the auto-save functionality for changing the workspace name in the Settings section. The current behavior required the user to press Enter in order to save the changes. However, with this fix, the change will be automatically saved without the need to press Enter. For example, if the user changes the workspace name from "Me" to "Destiny", closing the Settings by clicking on the gray area outside the Settings window will now result in the name being changed to "Destiny".

Types of Changes Made:

Implemented auto-save functionality for the workspace name in the Settings section. (used onChanged in place of onSubmitted)
Refactored the code to use a StatefulWidget instead of a StatelessWidget, in order to manage the lifecycle of the TextEditingController properly.
Tested the changes to ensure that the auto-save feature works as expected.
Added necessary comments to explain the changes made in the code and make it more readable.

Fixes #2033.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2065 **Author:** [@sshdopey](https://github.com/sshdopey) **Created:** 3/21/2023 **Status:** ✅ Merged **Merged:** 5/3/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/sync_name_on_change` --- ### 📝 Commits (2) - [`d5801e6`](https://github.com/AppFlowy-IO/AppFlowy/commit/d5801e6921766edd2ca8dc7c2827d561d6284c31) feat: sync name on change (AppFlowy-IO#2033) - [`e962a62`](https://github.com/AppFlowy-IO/AppFlowy/commit/e962a623e54d4b76faff1f56bb9f4543d77effe1) feat: sync name on change (AppFlowy-IO#2033) ### 📊 Changes **1 file changed** (+36 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_user_view.dart` (+36 -6) </details> ### 📄 Description ### Description: [Screencast from 21-03-2023 09:15:59.webm](https://user-images.githubusercontent.com/84413505/226550394-67c0316f-8362-445d-b9e2-a7710c936ad1.webm) This pull request fixes issue #2033, which was related to the auto-save functionality for changing the workspace name in the Settings section. The current behavior required the user to press Enter in order to save the changes. However, with this fix, the change will be automatically saved without the need to press Enter. For example, if the user changes the workspace name from "Me" to "Destiny", closing the Settings by clicking on the gray area outside the Settings window will now result in the name being changed to "Destiny". ### Types of Changes Made: Implemented auto-save functionality for the workspace name in the Settings section. (used onChanged in place of onSubmitted) Refactored the code to use a StatefulWidget instead of a StatelessWidget, in order to manage the lifecycle of the TextEditingController properly. Tested the changes to ensure that the auto-save feature works as expected. Added necessary comments to explain the changes made in the code and make it more readable. Fixes #2033. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>