[PR #2068] [MERGED] fix: slash menu responds to multiple key events #5082

New issue

Closed

opened 2026-03-23 22:17:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2068
Author: @squidrye
Created: 3/21/2023
Status: ✅ Merged
Merged: 3/21/2023
Merged by: @a-wallen

Base: main ← Head: fix-slash-menu-bug-2030

📝 Commits (3)

5c09929 fix: slash menu responds to multiple key events
10b6b9e refactor: suggested changes
f49e257 test: added tests for key events in selection menu widget

📊 Changes

2 files changed (+89 additions, -1 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_widget.dart (+8 -1)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart (+81 -0)

📄 Description

The slash menu responded to the tab and arrow keys however the user should be able to control the slash menu simultaneously with the tab and arrow keys. This PR fixes the issue.

Tab key now moves the currently highlighted selection to the right by one. User can move to the first element in the next row if the selection is at the button furthest to the right. Using the arrow keys, the selection moves in the direction specified by the arrow key.

https://user-images.githubusercontent.com/84044317/226590005-b5e1aae8-cc6d-4e63-85ec-80bb401e46c4.mp4

fixes #2030

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2068 **Author:** [@squidrye](https://github.com/squidrye) **Created:** 3/21/2023 **Status:** ✅ Merged **Merged:** 3/21/2023 **Merged by:** [@a-wallen](https://github.com/a-wallen) **Base:** `main` ← **Head:** `fix-slash-menu-bug-2030` --- ### 📝 Commits (3) - [`5c09929`](https://github.com/AppFlowy-IO/AppFlowy/commit/5c099297a42d7e0155fbd3a7f49fa1bb137b156c) fix: slash menu responds to multiple key events - [`10b6b9e`](https://github.com/AppFlowy-IO/AppFlowy/commit/10b6b9e5adc7c6c2c3b78f9824315c7a60375552) refactor: suggested changes - [`f49e257`](https://github.com/AppFlowy-IO/AppFlowy/commit/f49e2571facf01059d8e510793e72e4775ce4fe7) test: added tests for key events in selection menu widget ### 📊 Changes **2 files changed** (+89 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_widget.dart` (+8 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart` (+81 -0) </details> ### 📄 Description The slash menu responded to the tab and arrow keys however the user should be able to control the slash menu simultaneously with the tab and arrow keys. This PR fixes the issue. Tab key now moves the currently highlighted selection to the right by one. User can move to the first element in the next row if the selection is at the button furthest to the right. Using the arrow keys, the selection moves in the direction specified by the arrow key. https://user-images.githubusercontent.com/84044317/226590005-b5e1aae8-cc6d-4e63-85ec-80bb401e46c4.mp4 fixes #2030 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>