[PR #2111] [MERGED] [feat]: add image delete in document cover #5100

New issue

Closed

opened 2026-03-23 22:17:14 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2111
Author: @GouravShDev
Created: 3/26/2023
Status: ✅ Merged
Merged: 4/3/2023
Merged by: @LucasXu0

Base: main ← Head: feat/delete-cover-image

📝 Commits (9)

0565159 feat: add image delete in document cover
760cd9c fix: amend according to review comments
453fb65 fix: add initCompleter.future before using prefs
e6d4581 fix: show delete button on hover in CoverImageGrid
0843b83 feat: hover color on clear all and delete button
4dc8558 Merge branch 'main' into feat/delete-cover-image
e74048e fix: font color in clear all button in changecover
5713bee Merge branch 'main' into feat/delete-cover-image
82bb413 chore: add Clear All button fill color

📊 Changes

3 files changed (+266 additions, -99 deletions)

View changed files

📝 frontend/appflowy_flutter/assets/translations/en.json (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover.dart (+175 -99)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover_bloc.dart (+90 -0)

📄 Description

Fixes #2076

Added ChangeCoverPopoverBloc for mantaining state for images path List
Moved code for fetching previouslyPickedImages inside the bloc as it is app logic

Result

https://user-images.githubusercontent.com/74348508/227769253-0fbdb90f-2d62-4040-9ab8-96f1e21683f4.mp4

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2111 **Author:** [@GouravShDev](https://github.com/GouravShDev) **Created:** 3/26/2023 **Status:** ✅ Merged **Merged:** 4/3/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/delete-cover-image` --- ### 📝 Commits (9) - [`0565159`](https://github.com/AppFlowy-IO/AppFlowy/commit/056515943d934a9c83f64698d4e24930cd8dc0c4) feat: add image delete in document cover - [`760cd9c`](https://github.com/AppFlowy-IO/AppFlowy/commit/760cd9c411f368ea5e895426252e213b60a15458) fix: amend according to review comments - [`453fb65`](https://github.com/AppFlowy-IO/AppFlowy/commit/453fb65199daa5d11a1017d4caa54b60466f6dea) fix: add initCompleter.future before using prefs - [`e6d4581`](https://github.com/AppFlowy-IO/AppFlowy/commit/e6d45819ba461a068e227179024f5da6a5f110db) fix: show delete button on hover in CoverImageGrid - [`0843b83`](https://github.com/AppFlowy-IO/AppFlowy/commit/0843b8371244270056eec3c987f89111b06d221e) feat: hover color on clear all and delete button - [`4dc8558`](https://github.com/AppFlowy-IO/AppFlowy/commit/4dc85587ebfd0f30e105ed4291550bfff20b7d01) Merge branch 'main' into feat/delete-cover-image - [`e74048e`](https://github.com/AppFlowy-IO/AppFlowy/commit/e74048e323ea799ad80615aafddb5d7cc8015b08) fix: font color in clear all button in changecover - [`5713bee`](https://github.com/AppFlowy-IO/AppFlowy/commit/5713bee714993013f21eab2165c8c039426a3935) Merge branch 'main' into feat/delete-cover-image - [`82bb413`](https://github.com/AppFlowy-IO/AppFlowy/commit/82bb413978fd8857dc7b406ef07d9f388693ef81) chore: add Clear All button fill color ### 📊 Changes **3 files changed** (+266 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover.dart` (+175 -99) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover_bloc.dart` (+90 -0) </details> ### 📄 Description Fixes #2076 - Added ChangeCoverPopoverBloc for mantaining state for images path List - Moved code for fetching previouslyPickedImages inside the bloc as it is app logic # Result https://user-images.githubusercontent.com/74348508/227769253-0fbdb90f-2d62-4040-9ab8-96f1e21683f4.mp4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>