[PR #2115] [MERGED] fix: Fixed Italics via Single Asterisk #5101

New issue

Closed

opened 2026-03-23 22:17:14 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2115
Author: @JRS296
Created: 3/26/2023
Status: ✅ Merged
Merged: 3/30/2023
Merged by: @LucasXu0

Base: main ← Head: fixItalics

📝 Commits (7)

01717b3 Fixed Italics via Single Asterisk
d22addb Changed shift+asterisk to *
2a1b79b Mardown Syntax Function vaiable name changes + cleanup
b19cb02 feat: single asterisk to italic markdown command
25d50b9 Merge branch 'fixItalics' of https://github.com/JRS296/AppFlowy into fixItalics
c7801f0 Merge branch 'main' into fixItalics
9166ffb Merge remote-tracking branch 'origin/main' into fixItalics

📊 Changes

3 files changed (+95 additions, -0 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/markdown_syntax_to_styled_text.dart (+41 -0)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart (+5 -0)
📝 frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/markdown_syntax_to_styled_text_test.dart (+49 -0)

📄 Description

This fix is related to Issue as stated: #1059

Support for Italics Shortcut via Asterisk enabled
Minor tweaks with regards to keyboard command for Utilizing Asterisk
Shift+Digit8 -> Shift+Asterisk
Started Work on Unit Test for checking Italics - Currently researching ways to check for style of text within textnode. Marked as a TODO.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2115 **Author:** [@JRS296](https://github.com/JRS296) **Created:** 3/26/2023 **Status:** ✅ Merged **Merged:** 3/30/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fixItalics` --- ### 📝 Commits (7) - [`01717b3`](https://github.com/AppFlowy-IO/AppFlowy/commit/01717b36072388e623a2ef9792eda4ef10df92de) Fixed Italics via Single Asterisk - [`d22addb`](https://github.com/AppFlowy-IO/AppFlowy/commit/d22addb09ce40b72de61b1ef7cc5478a2078e24b) Changed shift+asterisk to * - [`2a1b79b`](https://github.com/AppFlowy-IO/AppFlowy/commit/2a1b79b6ea0fdebccebd9c05f58a1d0a001bf63d) Mardown Syntax Function vaiable name changes + cleanup - [`b19cb02`](https://github.com/AppFlowy-IO/AppFlowy/commit/b19cb02f8f8db82dbbd8ab8d2f52659ae70a713e) feat: single asterisk to italic markdown command - [`25d50b9`](https://github.com/AppFlowy-IO/AppFlowy/commit/25d50b903c48a47099b9c0b42b99339611f1b90f) Merge branch 'fixItalics' of https://github.com/JRS296/AppFlowy into fixItalics - [`c7801f0`](https://github.com/AppFlowy-IO/AppFlowy/commit/c7801f03a3ea4bd91de24e00329d3ea624fc3e73) Merge branch 'main' into fixItalics - [`9166ffb`](https://github.com/AppFlowy-IO/AppFlowy/commit/9166ffbb31406adb64698682bb6818d1fa7f392f) Merge remote-tracking branch 'origin/main' into fixItalics ### 📊 Changes **3 files changed** (+95 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/markdown_syntax_to_styled_text.dart` (+41 -0) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart` (+5 -0) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/test/service/internal_key_event_handlers/markdown_syntax_to_styled_text_test.dart` (+49 -0) </details> ### 📄 Description This fix is related to Issue as stated: #1059 - Support for Italics Shortcut via Asterisk enabled - Minor tweaks with regards to keyboard command for Utilizing Asterisk `Shift+Digit8 -> Shift+Asterisk` - Started Work on Unit Test for checking Italics - Currently researching ways to check for style of text within textnode. Marked as a TODO. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>