[PR #2132] [MERGED] feat: improved tooltip of toolbar items to include the connected shortcut commands, fixes #2053 #5116

Closed
opened 2026-03-23 22:17:19 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2132
Author: @Samiksha-Garg
Created: 3/28/2023
Status: Merged
Merged: 3/29/2023
Merged by: @LucasXu0

Base: mainHead: tooltip-toolbar-improvement


📝 Commits (1)

  • 8397b9b feat: improved tooltip of toolbar items

📊 Changes

2 files changed (+23 additions, -7 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart (+22 -7)
📝 frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item_widget.dart (+1 -0)

📄 Description

The tooltip for the toolbar item didn't contain the description of its connected shortcut. This PR adds this functionality for all those items which have shortcut.

It is hardcoded at the moment, as discussed in the PR description.

Screenshot 2023-03-28 at 8 51 19 PM

fix for issue #2053


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2132 **Author:** [@Samiksha-Garg](https://github.com/Samiksha-Garg) **Created:** 3/28/2023 **Status:** ✅ Merged **Merged:** 3/29/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `tooltip-toolbar-improvement` --- ### 📝 Commits (1) - [`8397b9b`](https://github.com/AppFlowy-IO/AppFlowy/commit/8397b9bff46b262d1210e35c0c2f6032014553d0) feat: improved tooltip of toolbar items ### 📊 Changes **2 files changed** (+23 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart` (+22 -7) 📝 `frontend/appflowy_flutter/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item_widget.dart` (+1 -0) </details> ### 📄 Description The tooltip for the toolbar item didn't contain the description of its connected shortcut. This PR adds this functionality for all those items which have shortcut. It is hardcoded at the moment, as discussed in the PR description. <img width="993" alt="Screenshot 2023-03-28 at 8 51 19 PM" src="https://user-images.githubusercontent.com/79906086/228294247-69cf1798-4208-4e12-8c7a-8e9855be8a0e.png"> fix for issue #2053 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:17:19 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5116
No description provided.