[PR #2148] [MERGED] Fix: Null check error in FlowyHoverContainer #5125

New issue

Closed

opened 2026-03-23 22:17:21 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2148
Author: @hyj1204
Created: 3/30/2023
Status: ✅ Merged
Merged: 3/31/2023
Merged by: @LucasXu0

Base: main ← Head: fix/FlowyHoverContainer_error

📝 Commits (3)

8b21147 fix: fix null check error in FlowyHoverContainer and delete unnecessary widget
d3f2f26 chore: set child to required in FlowyHoverContainer
5f05030 chore: delete unused import file

📊 Changes

2 files changed (+3 additions, -27 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/accessory/cell_accessory.dart (+0 -24)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/hover.dart (+3 -3)

📄 Description

I added a SizedBox.shrink() when there is no child in the FlowyHoverContainer in order to prevent the null check error happen again. Meanwhile, I delete the _background widget since it doesn't show any UI effect anyway.

Fixes #2147

https://user-images.githubusercontent.com/14248245/228919011-4dea812b-4356-4d75-b573-cb9ca5d04d12.mov

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2148 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 3/30/2023 **Status:** ✅ Merged **Merged:** 3/31/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/FlowyHoverContainer_error` --- ### 📝 Commits (3) - [`8b21147`](https://github.com/AppFlowy-IO/AppFlowy/commit/8b2114751d372ebc1e83162f4603c14abb53d067) fix: fix null check error in FlowyHoverContainer and delete unnecessary widget - [`d3f2f26`](https://github.com/AppFlowy-IO/AppFlowy/commit/d3f2f269ff6a47016a6fa850ffb4ad3a8817cd34) chore: set child to required in FlowyHoverContainer - [`5f05030`](https://github.com/AppFlowy-IO/AppFlowy/commit/5f05030ecfa802ef71f7da20a104f3cf3a56e80b) chore: delete unused import file ### 📊 Changes **2 files changed** (+3 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/accessory/cell_accessory.dart` (+0 -24) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/hover.dart` (+3 -3) </details> ### 📄 Description I added a `SizedBox.shrink()` when there is no child in the `FlowyHoverContainer` in order to prevent the null check error happen again. Meanwhile, I delete the `_background` widget since it doesn't show any UI effect anyway. Fixes #2147 https://user-images.githubusercontent.com/14248245/228919011-4dea812b-4356-4d75-b573-cb9ca5d04d12.mov --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>