[PR #2224] [MERGED] [Fix] delete cover image document update #5156

New issue

Closed

opened 2026-03-23 22:17:29 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2224
Author: @GouravShDev
Created: 4/9/2023
Status: ✅ Merged
Merged: 4/13/2023
Merged by: @LucasXu0

Base: main ← Head: fix/delete_cover_image

📝 Commits (9)

9dead5d fix: reset cover on deleting selected cover image
c3aa18e feat: add alert dialog on delete
85c6e50 fix: update cover image list when file not found
9f4c147 fix: missing const in change cover popup
cc27858 Merge branch 'main' of GouravShDev:GouravShDev/AppFlowy into fix/delete_cover_image
ab1ae97 fix: added dialog string in translation file
8686a52 fix: analytical issue in changeCoverPopover
b88a76e Merge branch 'main' of GouravShDev:GouravShDev/AppFlowy into fix/delete_cover_image
8c366c1 fix: added trailing commas in change_cover_popover

📊 Changes

4 files changed (+151 additions, -14 deletions)

View changed files

📝 frontend/appflowy_flutter/assets/translations/en.json (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover.dart (+110 -11)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover_bloc.dart (+27 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_node_widget.dart (+11 -1)

📄 Description

fixes #2173

Added alert dialog before deleting current document's cover image
Updates current document state on cover delete by user
Reset document cover state to "No Cover" if file not found while building widget

I am currently only checking for current document cover image when user deletes any image. I'm not sure how I can check if image is used by any other document.

https://user-images.githubusercontent.com/74348508/230787506-4b240bb2-2405-4c1e-b9d6-77b3b510acd6.mp4

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2224 **Author:** [@GouravShDev](https://github.com/GouravShDev) **Created:** 4/9/2023 **Status:** ✅ Merged **Merged:** 4/13/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/delete_cover_image` --- ### 📝 Commits (9) - [`9dead5d`](https://github.com/AppFlowy-IO/AppFlowy/commit/9dead5d99893e0816467705705aa01ccae22c035) fix: reset cover on deleting selected cover image - [`c3aa18e`](https://github.com/AppFlowy-IO/AppFlowy/commit/c3aa18ea35f9e0f9bf3227389ae59a70d470e01a) feat: add alert dialog on delete - [`85c6e50`](https://github.com/AppFlowy-IO/AppFlowy/commit/85c6e50821dd238326f4a87126d6d42d819eaae4) fix: update cover image list when file not found - [`9f4c147`](https://github.com/AppFlowy-IO/AppFlowy/commit/9f4c147f8ccc5fac448ce0da7ab723305362611f) fix: missing const in change cover popup - [`cc27858`](https://github.com/AppFlowy-IO/AppFlowy/commit/cc27858e782b0f8ffa629ff705da50d6feb4792e) Merge branch 'main' of GouravShDev:GouravShDev/AppFlowy into fix/delete_cover_image - [`ab1ae97`](https://github.com/AppFlowy-IO/AppFlowy/commit/ab1ae975dbd5a3b1f9315c6a00b0053ada4e023a) fix: added dialog string in translation file - [`8686a52`](https://github.com/AppFlowy-IO/AppFlowy/commit/8686a521bee86285ee79bf1979912919294fc83b) fix: analytical issue in changeCoverPopover - [`b88a76e`](https://github.com/AppFlowy-IO/AppFlowy/commit/b88a76e9bb0d9203d0fe20f7dbd0dd69da9ddd1a) Merge branch 'main' of GouravShDev:GouravShDev/AppFlowy into fix/delete_cover_image - [`8c366c1`](https://github.com/AppFlowy-IO/AppFlowy/commit/8c366c137890c6745ac9a08e90ba155b5e9f63bd) fix: added trailing commas in change_cover_popover ### 📊 Changes **4 files changed** (+151 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover.dart` (+110 -11) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/change_cover_popover_bloc.dart` (+27 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_node_widget.dart` (+11 -1) </details> ### 📄 Description fixes #2173 - Added alert dialog before deleting current document's cover image - Updates current document state on cover delete by user - Reset document cover state to "No Cover" if file not found while building widget I am currently only checking for current document cover image when user deletes any image. I'm not sure how I can check if image is used by any other document. https://user-images.githubusercontent.com/74348508/230787506-4b240bb2-2405-4c1e-b9d6-77b3b510acd6.mp4 #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>