[PR #2249] [MERGED] fix: fix multiple UI issues #5164

New issue

Closed

opened 2026-03-23 22:17:31 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2249
Author: @hyj1204
Created: 4/11/2023
Status: ✅ Merged
Merged: 4/14/2023
Merged by: @LucasXu0

Base: main ← Head: fix/fix_multiple_ui_issues

📝 Commits (4)

6d7b50d fix: put original borderRadius back to FieldCellButton
842b636 chore: remove the border of card when it is in dark mode
b58d805 chore: update NavigatorTextFieldDialog style and organize Insets
260c586 chore: delete unnecessary nullable field

📊 Changes

7 files changed (+33 additions, -24 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_detail.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart (+14 -14)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/size.dart (+5 -7)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_input.dart (+6 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/dialog/styled_dialogs.dart (+2 -1)

📄 Description

Feature Preview

This PR is to fix multiple UI issues as followings:

Put original borderRadius back to FieldCellButton
Header

Property Cell

Fix https://github.com/AppFlowy-IO/AppFlowy/pull/2193#discussion_r1162550363

Remove the border of card when it is in dark mode
Change the NavigatorTextFieldDialog style to center aligned with wider padding. It will be used in the pop-up dialog in https://github.com/AppFlowy-IO/AppFlowy/pull/2224 later.
Impacted Widgets:
Rename Page/Title

Create/name new page

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2249 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 4/11/2023 **Status:** ✅ Merged **Merged:** 4/14/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/fix_multiple_ui_issues` --- ### 📝 Commits (4) - [`6d7b50d`](https://github.com/AppFlowy-IO/AppFlowy/commit/6d7b50da29a6f559a09b78d379372de36890fe4e) fix: put original borderRadius back to FieldCellButton - [`842b636`](https://github.com/AppFlowy-IO/AppFlowy/commit/842b63661c605dcd0afbea4d6b1ce3d8f4523f6a) chore: remove the border of card when it is in dark mode - [`b58d805`](https://github.com/AppFlowy-IO/AppFlowy/commit/b58d8053c76db8616ef691e3251e481f79373875) chore: update NavigatorTextFieldDialog style and organize Insets - [`260c586`](https://github.com/AppFlowy-IO/AppFlowy/commit/260c58643a8a3bc455fd9435c707718143d4cadd) chore: delete unnecessary nullable field ### 📊 Changes **7 files changed** (+33 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/presentation/widgets/header/field_cell.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/row_detail.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart` (+14 -14) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/size.dart` (+5 -7) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_input.dart` (+6 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/dialog/styled_dialogs.dart` (+2 -1) </details> ### 📄 Description ### Feature Preview This PR is to fix multiple UI issues as followings: 1. Put original borderRadius back to FieldCellButton Header <img width="205" alt="image" src="https://user-images.githubusercontent.com/14248245/231312877-3027369b-4896-4ecd-8ccc-d1f9514a0d36.png"> Property Cell <img width="296" alt="image" src="https://user-images.githubusercontent.com/14248245/231312893-96c4bdb7-2824-4f42-bcb7-45265ab5b13e.png"> Fix https://github.com/AppFlowy-IO/AppFlowy/pull/2193#discussion_r1162550363 2. Remove the border of card when it is in dark mode <img width="333" alt="image" src="https://user-images.githubusercontent.com/14248245/231340223-3730127e-f1b4-4cfd-9700-31cb7f919022.png"> 3. Change the `NavigatorTextFieldDialog` style to center aligned with wider padding. It will be used in the pop-up dialog in https://github.com/AppFlowy-IO/AppFlowy/pull/2224 later. Impacted Widgets: Rename Page/Title <img width="421" alt="image" src="https://user-images.githubusercontent.com/14248245/231345064-e87d1e11-0159-497a-97ad-14dbc49b1867.png"> <img width="425" alt="image" src="https://user-images.githubusercontent.com/14248245/231346499-5bbf8170-2cb4-4087-919c-17198d839e6c.png"> Create/name new page <img width="425" alt="image" src="https://user-images.githubusercontent.com/14248245/231345192-995d7166-1675-4a27-8b7f-8143c4498bb8.png"> ---  #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [X] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>