[PR #2287] [MERGED] feat: add url validation in cell_editor #5182

New issue

Closed

opened 2026-03-23 22:17:36 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2287
Author: @rwt-2001
Created: 4/17/2023
Status: ✅ Merged
Merged: 4/23/2023
Merged by: @annieappflowy

Base: main ← Head: feat/url_validation

📝 Commits (3)

1e3817b feat: add url validation in cell_editor
69fc28b fix: url validation in cell editor
6640395 feat: add UriFailure in url_validator

📊 Changes

4 files changed (+38 additions, -2 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/core/helpers/helpers.dart (+1 -0)
➕ frontend/appflowy_flutter/lib/core/helpers/url_validator.dart (+21 -0)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/url_cell/cell_editor.dart (+14 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/snap_bar.dart (+2 -1)

📄 Description

Fixes #2199

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2287 **Author:** [@rwt-2001](https://github.com/rwt-2001) **Created:** 4/17/2023 **Status:** ✅ Merged **Merged:** 4/23/2023 **Merged by:** [@annieappflowy](https://github.com/annieappflowy) **Base:** `main` ← **Head:** `feat/url_validation` --- ### 📝 Commits (3) - [`1e3817b`](https://github.com/AppFlowy-IO/AppFlowy/commit/1e3817be3a690c9fad7c8634fc15ce193dca732b) feat: add url validation in cell_editor - [`69fc28b`](https://github.com/AppFlowy-IO/AppFlowy/commit/69fc28b6ed5594f4eb0051542ed6ce3449e9b910) fix: url validation in cell editor - [`6640395`](https://github.com/AppFlowy-IO/AppFlowy/commit/66403959ac445d9e983e16de747063d483fafce1) feat: add UriFailure in url_validator ### 📊 Changes **4 files changed** (+38 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/core/helpers/helpers.dart` (+1 -0) ➕ `frontend/appflowy_flutter/lib/core/helpers/url_validator.dart` (+21 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/url_cell/cell_editor.dart` (+14 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/snap_bar.dart` (+2 -1) </details> ### 📄 Description   Fixes #2199 ### Feature Preview ![image](https://user-images.githubusercontent.com/96018275/232580317-7d4165a0-e7d4-4770-828b-71f9a49110a3.png)  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>