[PR #2307] [MERGED] feat: editor theme improvement #5183

New issue

Closed

opened 2026-03-23 22:17:36 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2307
Author: @hyj1204
Created: 4/21/2023
Status: ✅ Merged
Merged: 4/21/2023
Merged by: @LucasXu0

Base: main ← Head: feat/editor_theme_improvement

📝 Commits (6)

b1dad33 chore: make editor style adapt to theme data and add toolbar color
6a556c1 chore: link to local path
27c3478 chore: add pop up menu style
199bc68 chore: link to editor main branch
84d115d chore: reset editor path
2c5c194 chore: upgrade appflowy_editor

📊 Changes

10 files changed (+110 additions, -67 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/editor_styles.dart (+47 -16)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_node_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/emoji_popover.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/appearance.dart (+2 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/colorscheme.dart (+3 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/dandelion.dart (+47 -45)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart (+4 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lavender.dart (+3 -0)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)

📄 Description

This PR should be merged after the new release of Appflowy Editor(0.1.9)

Feature Preview

Refactor the customEditorTheme to set the editor style adapt to current ThemeData. The following UIs has been updated.

Selection Text color and tool bar background color

Highlight color

Update the code style from the toolbar
Set the pop up menu style in Editor and it will impact

Color pickers

Link pop up menu

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2307 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 4/21/2023 **Status:** ✅ Merged **Merged:** 4/21/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/editor_theme_improvement` --- ### 📝 Commits (6) - [`b1dad33`](https://github.com/AppFlowy-IO/AppFlowy/commit/b1dad33be1255d385418bedc693b31653c7ca772) chore: make editor style adapt to theme data and add toolbar color - [`6a556c1`](https://github.com/AppFlowy-IO/AppFlowy/commit/6a556c1863a90dc80538678d4a18352104500e09) chore: link to local path - [`27c3478`](https://github.com/AppFlowy-IO/AppFlowy/commit/27c3478e165f0ffeb5247cf23d2514974004dc94) chore: add pop up menu style - [`199bc68`](https://github.com/AppFlowy-IO/AppFlowy/commit/199bc68741faaf7e1b10b8dca9cc30098606d6b2) chore: link to editor main branch - [`84d115d`](https://github.com/AppFlowy-IO/AppFlowy/commit/84d115dca6ac8ec1a110c9bc033b3d0f430f97df) chore: reset editor path - [`2c5c194`](https://github.com/AppFlowy-IO/AppFlowy/commit/2c5c194084242356d44e10d9f9b4abd1fcead189) chore: upgrade appflowy_editor ### 📊 Changes **10 files changed** (+110 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/editor_styles.dart` (+47 -16) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/cover_node_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/cover/emoji_popover.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/appearance.dart` (+2 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/colorscheme.dart` (+3 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/dandelion.dart` (+47 -45) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/default_colorscheme.dart` (+4 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/lavender.dart` (+3 -0) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) </details> ### 📄 Description This PR should be merged after the new release of Appflowy Editor(0.1.9) ### Feature Preview 1. Refactor the `customEditorTheme` to set the editor style adapt to current ThemeData. The following UIs has been updated. - Selection Text color and tool bar background color ![image](https://user-images.githubusercontent.com/14248245/233537501-3b02352b-9c71-4cdd-bcf6-9ed6e5d12125.png) ![image](https://user-images.githubusercontent.com/14248245/233537557-8397c543-5199-43f2-a206-93f96c6beeac.png) - Highlight color ![image](https://user-images.githubusercontent.com/14248245/233537728-68b931a8-02b9-4cd0-9c3d-70b4dff0d85f.png) ![image](https://user-images.githubusercontent.com/14248245/233537665-610f144c-cdbe-4b62-a56e-2e13c825e9c0.png) 2. Update the code style from the toolbar ![image](https://user-images.githubusercontent.com/14248245/233508672-d1f168fa-e198-4490-b51d-ce0501ef81d4.png) ![image](https://user-images.githubusercontent.com/14248245/233508708-51b55742-6ea7-419a-ae3a-7a9c2c1ed238.png) 3. Set the pop up menu style in Editor and it will impact - Color pickers ![image](https://user-images.githubusercontent.com/14248245/233508972-cd8ae5cd-63ce-4204-832c-f68db3403d1d.png) ![image](https://user-images.githubusercontent.com/14248245/233538611-918462d3-b522-4a8b-9999-f6a253234d99.png) - Link pop up menu ![image](https://user-images.githubusercontent.com/14248245/233509083-d70aa5dc-5b2c-47da-b286-c2a055b80888.png) ![image](https://user-images.githubusercontent.com/14248245/233538489-9c80804f-6b85-4632-99e2-4161d9e9237e.png) ---  #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [X] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>