[PR #2317] [MERGED] feat: change the UI of language selector #5186

New issue

Closed

opened 2026-03-23 22:17:37 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2317
Author: @hyj1204
Created: 4/21/2023
Status: ✅ Merged
Merged: 4/25/2023
Merged by: @LucasXu0

Base: main ← Head: feat/language_selector_improvement

📝 Commits (3)

e939121 feat: change the UI of language selector
bcba39d chore: clean up code
9403622 chore: delete unnecessary code and clean up

📊 Changes

3 files changed (+101 additions, -77 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/application/appearance.dart (+14 -8)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_language_view.dart (+83 -65)

📄 Description

This PR is to change the current language picker UI along with fix #2291.

Feature Preview

https://user-images.githubusercontent.com/14248245/233741806-04d02ea7-a4f3-43c5-a489-5709e66315a2.mov

Initially, I attempted to change the text color when it is hovered, but I realized that it was difficult to achieve due to the limitations of the DropdownButton. I considered importing a dropdownbutton related package(just for changing the text color?) or creating a customized DropdownButton(time-consuming). Instead, I think the best approach at the moment is to use the same popup-style widget in the theme setting, which would maintain consistency throughout the application setting page too.

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2317 **Author:** [@hyj1204](https://github.com/hyj1204) **Created:** 4/21/2023 **Status:** ✅ Merged **Merged:** 4/25/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/language_selector_improvement` --- ### 📝 Commits (3) - [`e939121`](https://github.com/AppFlowy-IO/AppFlowy/commit/e939121948969a5da447f7dae5acef3bd92a862b) feat: change the UI of language selector - [`bcba39d`](https://github.com/AppFlowy-IO/AppFlowy/commit/bcba39d2881e6c35d14827f3529426f8bf5fe597) chore: clean up code - [`9403622`](https://github.com/AppFlowy-IO/AppFlowy/commit/94036226fec6043e49e786d1d206e798411c02f2) chore: delete unnecessary code and clean up ### 📊 Changes **3 files changed** (+101 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/application/appearance.dart` (+14 -8) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_language_view.dart` (+83 -65) </details> ### 📄 Description This PR is to change the current language picker UI along with fix #2291. ### Feature Preview https://user-images.githubusercontent.com/14248245/233741806-04d02ea7-a4f3-43c5-a489-5709e66315a2.mov Initially, I attempted to change the text color when it is hovered, but I realized that it was difficult to achieve due to the limitations of the DropdownButton. I considered importing a dropdownbutton related package(just for changing the text color?) or creating a customized DropdownButton(time-consuming). Instead, I think the best approach at the moment is to use the same popup-style widget in the theme setting, which would maintain consistency throughout the application setting page too. #### PR Checklist - [X] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [X] I've listed at least one issue that this PR fixes in the description above. - [X] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [X] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>