[PR #2351] [MERGED] chore: grid row page detail redesign #5199

Closed
opened 2026-03-23 22:17:40 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2351
Author: @richardshiue
Created: 4/25/2023
Status: Merged
Merged: 4/30/2023
Merged by: @appflowy

Base: mainHead: delete-row-using-detail-page


📝 Commits (9)

  • e3fca92 chore: grid row page detail update
  • 0247ae4 chore: update row_detail.dart
  • f07cf14 chore: more adaptive and code cleanup
  • d65b328 feat: duplicate row
  • 4fa65d1 feat: duplicate calendar event
  • d84d6c7 fix: ci
  • de51c68 feat: show other options
  • 9a4e597 fix: show include time
  • 6071c23 fix: add key in RowCard to avoid incorrect data when open the row page

📊 Changes

27 files changed (+607 additions, -342 deletions)

View changed files

📝 frontend/appflowy_flutter/assets/translations/en.json (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_controller.dart (+1 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart (+7 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/view/view_cache.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart (+5 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/application/calendar_bloc.dart (+46 -16)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart (+146 -77)
📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_page.dart (+9 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/application/grid_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_detail_bloc.dart (+18 -7)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card.dart (+67 -28)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_bloc.dart (+27 -40)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_cell_builder.dart (+8 -5)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/card_cell.dart (+42 -9)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/checkbox_card_cell.dart (+10 -7)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/date_card_cell.dart (+12 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/select_option_card_cell.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/text_card_cell.dart (+16 -3)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/container/card_container.dart (+2 -2)

...and 7 more files

📄 Description

This PR introduces a new design of the UI of opening grid row/kanban board card/calendar event as page.

  • Add a right sidebar to include row actions. For now, there is only the ability to delete the row.
  • Removed the thick scroll bar for a more subtle version. Also increase the scrollbar margin in the main axis to account for the rounded corners (doesn't seem to cause regressions on other popovers)
  • Reorganized the layout of the page to allow future implementation of #2183.

fixes #1993

Feature Preview

https://user-images.githubusercontent.com/71320345/234302277-b7fee5d4-cda2-4360-8374-db9dd5ee716b.mp4


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2351 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 4/25/2023 **Status:** ✅ Merged **Merged:** 4/30/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `delete-row-using-detail-page` --- ### 📝 Commits (9) - [`e3fca92`](https://github.com/AppFlowy-IO/AppFlowy/commit/e3fca9241afbe6bd177e3135abc85bc5b9dff649) chore: grid row page detail update - [`0247ae4`](https://github.com/AppFlowy-IO/AppFlowy/commit/0247ae4b18940d2edf7ac477974157020891bdcd) chore: update row_detail.dart - [`f07cf14`](https://github.com/AppFlowy-IO/AppFlowy/commit/f07cf1435be1a67a3b930ece89d630bc9ff3c4bd) chore: more adaptive and code cleanup - [`d65b328`](https://github.com/AppFlowy-IO/AppFlowy/commit/d65b32898203c9e7a3e43f5e9fef70da30c049c4) feat: duplicate row - [`4fa65d1`](https://github.com/AppFlowy-IO/AppFlowy/commit/4fa65d1be6ab704e48d280bc2707e9be0d24fd31) feat: duplicate calendar event - [`d84d6c7`](https://github.com/AppFlowy-IO/AppFlowy/commit/d84d6c78e3e57c78e48a7cabf8a97c5303dac072) fix: ci - [`de51c68`](https://github.com/AppFlowy-IO/AppFlowy/commit/de51c6880f5be71efb05fd05b6d0cf4692abb7a7) feat: show other options - [`9a4e597`](https://github.com/AppFlowy-IO/AppFlowy/commit/9a4e5978c0b8ec7aa07be19f0b8c15df2139a562) fix: show include time - [`6071c23`](https://github.com/AppFlowy-IO/AppFlowy/commit/6071c23f0ce8679e3025f90b73877b1cd2d9b67e) fix: add key in RowCard to avoid incorrect data when open the row page ### 📊 Changes **27 files changed** (+607 additions, -342 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_controller.dart` (+1 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart` (+7 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/view/view_cache.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/application/board_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/board/presentation/board_page.dart` (+5 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/application/calendar_bloc.dart` (+46 -16) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart` (+146 -77) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_page.dart` (+9 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/application/grid_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/grid/application/row/row_detail_bloc.dart` (+18 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card.dart` (+67 -28) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_bloc.dart` (+27 -40) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/card_cell_builder.dart` (+8 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/card_cell.dart` (+42 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/checkbox_card_cell.dart` (+10 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/date_card_cell.dart` (+12 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/select_option_card_cell.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/cells/text_card_cell.dart` (+16 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/card/container/card_container.dart` (+2 -2) _...and 7 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> This PR introduces a new design of the UI of opening grid row/kanban board card/calendar event as page. - Add a right sidebar to include row actions. For now, there is only the ability to delete the row. - Removed the thick scroll bar for a more subtle version. Also increase the scrollbar margin in the main axis to account for the rounded corners (doesn't seem to cause regressions on other popovers) - Reorganized the layout of the page to allow future implementation of #2183. fixes #1993 <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview https://user-images.githubusercontent.com/71320345/234302277-b7fee5d4-cda2-4360-8374-db9dd5ee716b.mp4 <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:17:40 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5199
No description provided.