[PR #2444] [MERGED] fix: default include time #5236

New issue

Closed

opened 2026-03-23 22:17:50 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2444
Author: @richardshiue
Created: 5/3/2023
Status: ✅ Merged
Merged: 5/4/2023
Merged by: @appflowy

Base: main ← Head: default-include-time

📝 Commits (2)

8b4a57e fix: default include time
353a1a6 chore: clarify logic and add comments

📊 Changes

2 files changed (+30 additions, -12 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_data_persistence.dart (+1 -6)
📝 frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cal_bloc.dart (+29 -6)

📄 Description

Regardless of whether a date has previously been selected, clicking toggle include time in a cell that previously did not have time will enter the current time for you.

fix: #1800
fix: #2440

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2444 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 5/3/2023 **Status:** ✅ Merged **Merged:** 5/4/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `default-include-time` --- ### 📝 Commits (2) - [`8b4a57e`](https://github.com/AppFlowy-IO/AppFlowy/commit/8b4a57e1bda0558742749727db80ca31e2b0bb5e) fix: default include time - [`353a1a6`](https://github.com/AppFlowy-IO/AppFlowy/commit/353a1a61da1d6c3a9cddf7528e32691fa5d60d81) chore: clarify logic and add comments ### 📊 Changes **2 files changed** (+30 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_data_persistence.dart` (+1 -6) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/widgets/row/cells/date_cell/date_cal_bloc.dart` (+29 -6) </details> ### 📄 Description Regardless of whether a date has previously been selected, clicking toggle include time in a cell that previously did not have time will enter the current time for you. fix: #1800 fix: #2440  ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>