[PR #2479] [CLOSED] fix - Set default theme to Default from light in the Appearance tab #5250

Closed
opened 2026-03-23 22:17:54 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2479
Author: @gitstart
Created: 5/8/2023
Status: Closed

Base: mainHead: FLOWY-OSS-16


📝 Commits (1)

  • d056a2a fix: Set default theme to Default from light in the Appearance tab

📊 Changes

3 files changed (+43 additions, -0 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/colorscheme.dart (+3 -0)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/theme.dart (+14 -0)
frontend/appflowy_flutter/test/unit_test/select_app_theme_test.dart (+26 -0)

📄 Description

PR Description

This PR replaces 'light' text with 'Default' for the default Theme in the Appearance panel, fixes #2402.

Issue screenshot
image

Fix Description

The 'light' text that appears on the UI comes from the API, which is now replaced with Default text when being displayed on the UI.

[Fix] Screenshot
image

[Fix] Recording

https://user-images.githubusercontent.com/13991373/235838709-271a3a20-a7e7-46f1-ba63-06151ac873f7.mov


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2479 **Author:** [@gitstart](https://github.com/gitstart) **Created:** 5/8/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `FLOWY-OSS-16` --- ### 📝 Commits (1) - [`d056a2a`](https://github.com/AppFlowy-IO/AppFlowy/commit/d056a2a9ab798c30ab2bb4862e2611d50792cd03) fix: Set default theme to Default from light in the Appearance tab ### 📊 Changes **3 files changed** (+43 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/colorscheme/colorscheme.dart` (+3 -0) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/theme.dart` (+14 -0) ➕ `frontend/appflowy_flutter/test/unit_test/select_app_theme_test.dart` (+26 -0) </details> ### 📄 Description ### PR Description This PR replaces 'light' text with 'Default' for the default Theme in the Appearance panel, fixes [#2402](https://github.com/AppFlowy-IO/AppFlowy/issues/2402). > Issue screenshot ![image](https://user-images.githubusercontent.com/13991373/235838587-e843ec51-fc3b-4f6a-8035-f31a7ffd8cd8.png) ### Fix Description The 'light' text that appears on the UI comes from the API, which is now replaced with `Default` text when being displayed on the UI. > [Fix] Screenshot ![image](https://user-images.githubusercontent.com/13991373/235838696-2aa45ba1-5712-4ddc-b42f-f50347f67776.png) > [Fix] Recording https://user-images.githubusercontent.com/13991373/235838709-271a3a20-a7e7-46f1-ba63-06151ac873f7.mov --- ### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:17:54 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5250
No description provided.