[PR #2493] [MERGED] fix: don't show whitespace when no options are selected #5263

New issue

Closed

opened 2026-03-23 22:17:57 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:17:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2493
Author: @richardshiue
Created: 5/10/2023
Status: ✅ Merged
Merged: 5/15/2023
Merged by: @appflowy

Base: main ← Head: calendar-day-select

📝 Commits (1)

3e3ebfe fix: don't show whitespace when no options are selected

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart (+3 -0)

📄 Description

Notice how there is extra whitespace when the visibility of the select option field is being toggled

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/365c9535-1e40-491f-9bd8-d7d0821d833f

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2493 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 5/10/2023 **Status:** ✅ Merged **Merged:** 5/15/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `calendar-day-select` --- ### 📝 Commits (1) - [`3e3ebfe`](https://github.com/AppFlowy-IO/AppFlowy/commit/3e3ebfe08ac92d3b392050ae4957f6fc278f121b) fix: don't show whitespace when no options are selected ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database_view/calendar/presentation/calendar_day.dart` (+3 -0) </details> ### 📄 Description Notice how there is extra whitespace when the visibility of the select option field is being toggled ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/365c9535-1e40-491f-9bd8-d7d0821d833f ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>