[PR #2524] [CLOSED] Feat/block toolbar #5277

Closed
opened 2026-03-23 22:18:01 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2524
Author: @qinluhe
Created: 5/13/2023
Status: Closed

Base: mainHead: feat/block-toolbar


📝 Commits (10+)

  • 3619fad chore: add edit / create field test
  • a3f4dfa chore: add delete field test
  • e5a1bd2 chore: change log class arguments
  • c743089 chore: delete/create row
  • fd135fb chore: set tracing log to debug level
  • f58c91f fix: filter notification with id
  • 2e4df44 chore: add get single select type option data
  • 08bb4e4 Merge remote-tracking branch 'origin/feat/appflowy_tauri_3' into feat/appflowy_tauri_3
  • c35db5c fix: high cpu usage
  • dcf8fd5 chore: format code

📊 Changes

731 files changed (+40851 additions, -6339 deletions)

View changed files

📝 .github/workflows/flutter_ci.yaml (+2 -0)
📝 .github/workflows/rust_ci.yaml (+2 -0)
📝 .github/workflows/tauri_ci.yaml (+10 -12)
📝 .gitignore (+2 -0)
📝 frontend/.vscode/launch.json (+2 -2)
📝 frontend/.vscode/tasks.json (+1 -1)
📝 frontend/Makefile.toml (+4 -0)
frontend/appflowy_flutter/lib/core/document_notification.dart (+24 -0)
📝 frontend/appflowy_flutter/lib/core/folder_notification.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/core/grid_notification.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_cache.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_controller.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_controller_builder.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_data_persistence.dart (+6 -11)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_listener.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_service.dart (+8 -7)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart (+13 -13)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/database_service.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/database_view_service.dart (+17 -22)
📝 frontend/appflowy_flutter/lib/plugins/database_view/application/defines.dart (+6 -5)

...and 80 more files

📄 Description

This PR base on https://github.com/AppFlowy-IO/AppFlowy/pull/2514

Feature Preview

  • Support to show text action toolbar when the selection exists and the range is not collapsed
    image

  • Support format in the toolbar

  • Support to turn into other block in the toolbar
    image


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2524 **Author:** [@qinluhe](https://github.com/qinluhe) **Created:** 5/13/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/block-toolbar` --- ### 📝 Commits (10+) - [`3619fad`](https://github.com/AppFlowy-IO/AppFlowy/commit/3619fadf572c20bd4680da9bd6cd79e88832422a) chore: add edit / create field test - [`a3f4dfa`](https://github.com/AppFlowy-IO/AppFlowy/commit/a3f4dfacba302d3344fb343c40beca83a8579838) chore: add delete field test - [`e5a1bd2`](https://github.com/AppFlowy-IO/AppFlowy/commit/e5a1bd2c525ae7bc60a4d98fa7dde13274b027bf) chore: change log class arguments - [`c743089`](https://github.com/AppFlowy-IO/AppFlowy/commit/c74308999d9410a60f1ff2e368bb839e3f000766) chore: delete/create row - [`fd135fb`](https://github.com/AppFlowy-IO/AppFlowy/commit/fd135fb664de23e18d1f7c0cb588ab9fccc97f28) chore: set tracing log to debug level - [`f58c91f`](https://github.com/AppFlowy-IO/AppFlowy/commit/f58c91fb3fd9c200d1cf7576884a37c7a0f2686c) fix: filter notification with id - [`2e4df44`](https://github.com/AppFlowy-IO/AppFlowy/commit/2e4df44c292c9aacac3ee95fb7f168567d0f0dd1) chore: add get single select type option data - [`08bb4e4`](https://github.com/AppFlowy-IO/AppFlowy/commit/08bb4e411697522d95a36ee1e33a841d081db44a) Merge remote-tracking branch 'origin/feat/appflowy_tauri_3' into feat/appflowy_tauri_3 - [`c35db5c`](https://github.com/AppFlowy-IO/AppFlowy/commit/c35db5c2a232b0855b455739e6d87ae02fa7126d) fix: high cpu usage - [`dcf8fd5`](https://github.com/AppFlowy-IO/AppFlowy/commit/dcf8fd538dfcdfff91136a8ca773df8d31fda2ea) chore: format code ### 📊 Changes **731 files changed** (+40851 additions, -6339 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/flutter_ci.yaml` (+2 -0) 📝 `.github/workflows/rust_ci.yaml` (+2 -0) 📝 `.github/workflows/tauri_ci.yaml` (+10 -12) 📝 `.gitignore` (+2 -0) 📝 `frontend/.vscode/launch.json` (+2 -2) 📝 `frontend/.vscode/tasks.json` (+1 -1) 📝 `frontend/Makefile.toml` (+4 -0) ➕ `frontend/appflowy_flutter/lib/core/document_notification.dart` (+24 -0) 📝 `frontend/appflowy_flutter/lib/core/folder_notification.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/core/grid_notification.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_cache.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_controller.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_controller_builder.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_data_persistence.dart` (+6 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_listener.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/cell/cell_service.dart` (+8 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/database_controller.dart` (+13 -13) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/database_service.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/database_view_service.dart` (+17 -22) 📝 `frontend/appflowy_flutter/lib/plugins/database_view/application/defines.dart` (+6 -5) _...and 80 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> This PR base on https://github.com/AppFlowy-IO/AppFlowy/pull/2514 <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] Support to show text action toolbar when the selection exists and the range is not collapsed <img width="651" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/108015703/873dd109-31bb-42d7-8634-a4ffb48c88c1"> - [x] Support format in the toolbar - [x] Support to turn into other block in the toolbar <img width="635" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/108015703/1f84bf17-59ce-4e07-8482-a35bc3f902be"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 22:18:01 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#5277
No description provided.