[PR #2538] [MERGED] fix: select all in code block handler #5287

New issue

Closed

opened 2026-03-23 22:18:04 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2538
Author: @Xazin
Created: 5/15/2023
Status: ✅ Merged
Merged: 5/22/2023
Merged by: @LucasXu0

Base: develop ← Head: fix/gh-2320/select-all-in-code-block

📝 Commits (3)

27a19e9 fix: select all in code block handler
b0fe61c fix: do not force unwrap in toDocument
ceb9385 fix: refactor unwrapping and selection

📊 Changes

2 files changed (+51 additions, -6 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/application/document_data_pb_extension.dart (+14 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/code_block/code_block_shortcut_event.dart (+37 -0)

📄 Description

Closes: #2320

Feature Preview

https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/2398706a-0208-4814-937b-2c9a1d30b341

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2538 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 5/15/2023 **Status:** ✅ Merged **Merged:** 5/22/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `develop` ← **Head:** `fix/gh-2320/select-all-in-code-block` --- ### 📝 Commits (3) - [`27a19e9`](https://github.com/AppFlowy-IO/AppFlowy/commit/27a19e9b6f51b4e00397e03a16a4683a89103268) fix: select all in code block handler - [`b0fe61c`](https://github.com/AppFlowy-IO/AppFlowy/commit/b0fe61cb9f241d2f4869e79d5a4cb866aedd9566) fix: do not force unwrap in toDocument - [`ceb9385`](https://github.com/AppFlowy-IO/AppFlowy/commit/ceb9385b150559ec10e4030d24505551e2b91717) fix: refactor unwrapping and selection ### 📊 Changes **2 files changed** (+51 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/application/document_data_pb_extension.dart` (+14 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/code_block/code_block_shortcut_event.dart` (+37 -0) </details> ### 📄 Description Closes: #2320   ### Feature Preview https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/2398706a-0208-4814-937b-2c9a1d30b341  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>