[PR #2550] [MERGED] chore: clean up code #5293

New issue

Closed

opened 2026-03-23 22:18:05 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2550
Author: @richardshiue
Created: 5/17/2023
Status: ✅ Merged
Merged: 5/19/2023
Merged by: @appflowy

Base: develop ← Head: early-escape

📝 Commits (1)

f39bdb0 refactor: clean up code

📊 Changes

3 files changed (+71 additions, -94 deletions)

View changed files

📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_tests.rs (+4 -2)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs (+66 -84)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs (+1 -8)

📄 Description

Split off a portion of repeated logic into a separate function in apply_changeset.
Improve readability in some parts
early escape from timezone parsing if the timezone_id string is empty

Feature Preview

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2550 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 5/17/2023 **Status:** ✅ Merged **Merged:** 5/19/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `develop` ← **Head:** `early-escape` --- ### 📝 Commits (1) - [`f39bdb0`](https://github.com/AppFlowy-IO/AppFlowy/commit/f39bdb07a733412dfb33c604cf2d52bf1566e709) refactor: clean up code ### 📊 Changes **3 files changed** (+71 additions, -94 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_tests.rs` (+4 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs` (+66 -84) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option_entities.rs` (+1 -8) </details> ### 📄 Description - Split off a portion of repeated logic into a separate function in `apply_changeset`. - Improve readability in some parts - early escape from timezone parsing if the timezone_id string is empty ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>