[PR #2556] [CLOSED] fix: Divider shortcut does not work on lines with existing text #5298

New issue

Closed

opened 2026-03-23 22:18:07 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2556
Author: @gitstart
Created: 5/17/2023
Status: ❌ Closed

Base: main ← Head: FLOWY-OSS-19

📝 Commits (2)

f1e5c17 fix: Divider shortcut does not work on lines with existing text
cc555af fix: Divider shortcut does not work on lines with existing text

📊 Changes

1 file changed (+25 additions, -9 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/divider/divider_shortcut_event.dart (+25 -9)

📄 Description

fixes #2140

This PR makes the divider shortcut (---) work on lines with existing text

Issue Video

https://www.loom.com/share/50083bab0556446fb2b4c0c005e14c64

Fix video

https://www.loom.com/share/b132d5076eab4b58b1a05869e7988f7c

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2556 **Author:** [@gitstart](https://github.com/gitstart) **Created:** 5/17/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `FLOWY-OSS-19` --- ### 📝 Commits (2) - [`f1e5c17`](https://github.com/AppFlowy-IO/AppFlowy/commit/f1e5c17e16954a2b857b5cee129108e0ee2f6077) fix: Divider shortcut does not work on lines with existing text - [`cc555af`](https://github.com/AppFlowy-IO/AppFlowy/commit/cc555afec80ddc8084646fcf0d56e4205577ea8b) fix: Divider shortcut does not work on lines with existing text ### 📊 Changes **1 file changed** (+25 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/divider/divider_shortcut_event.dart` (+25 -9) </details> ### 📄 Description fixes [#2140](https://github.com/AppFlowy-IO/AppFlowy/issues/2140) This PR makes the divider shortcut (---) work on lines with existing text ### Issue Video https://www.loom.com/share/50083bab0556446fb2b4c0c005e14c64 ### Fix video https://www.loom.com/share/b132d5076eab4b58b1a05869e7988f7c --- ### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>