[PR #2560] [CLOSED] feature: added emoji picker shortcut #5302

New issue

Closed

opened 2026-03-23 22:18:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2560
Author: @nurmukhametdaniyar
Created: 5/18/2023
Status: ❌ Closed

Base: main ← Head: develop_emoji_shortcut_2038

📝 Commits (10+)

f0b2899 feature: added emoji picker shortcut in the develop branch
33f4ce9 test: added integration test
72fbddb refactor: simplifying adding emoji picker shortcut to command shortcuts list
4996661 refactor: made onExit callback optional in EmojiSelectionMenu
db66d37 feature: changed emoji picker shortcut to cmd/ctrl+alt+e
35e86d2 refactor: abstracted menu sizes away in a separate class
6f590b3 test: updated integration test with the latest shortcut
6ce6679 Update frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/emoji_picker/emoji_menu_item.dart
18274d0 refactor: changed to get context from editor state
a7cdf65 Merge branch 'main' into develop_emoji_shortcut_2038

📊 Changes

8 files changed (+149 additions, -11 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/command_shortcut_tests.dart (+61 -0)
📝 frontend/appflowy_flutter/integration_test/runner.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/emoji_picker/emoji_menu_item.dart (+3 -3)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/emoji_picker/emoji_shortcut_event.dart (+67 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart (+1 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/layout/sizes.dart (+6 -0)
📝 frontend/rust-lib/Cargo.lock (+8 -8)

📄 Description

Feature Preview

fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2038

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2560 **Author:** [@nurmukhametdaniyar](https://github.com/nurmukhametdaniyar) **Created:** 5/18/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `develop_emoji_shortcut_2038` --- ### 📝 Commits (10+) - [`f0b2899`](https://github.com/AppFlowy-IO/AppFlowy/commit/f0b289974dc24f6262d815f030971e6297ca278d) feature: added emoji picker shortcut in the develop branch - [`33f4ce9`](https://github.com/AppFlowy-IO/AppFlowy/commit/33f4ce9e3e8375416285d93ee86aabf2d84c26c2) test: added integration test - [`72fbddb`](https://github.com/AppFlowy-IO/AppFlowy/commit/72fbddb5cbd2cfe8c8f5f31da6918d18bb881674) refactor: simplifying adding emoji picker shortcut to command shortcuts list - [`4996661`](https://github.com/AppFlowy-IO/AppFlowy/commit/4996661f3e38e340a531db04e02b0a19a75a6631) refactor: made onExit callback optional in EmojiSelectionMenu - [`db66d37`](https://github.com/AppFlowy-IO/AppFlowy/commit/db66d371626c8365d29da868d19dcaae1c87a7d8) feature: changed emoji picker shortcut to cmd/ctrl+alt+e - [`35e86d2`](https://github.com/AppFlowy-IO/AppFlowy/commit/35e86d2372febc46086ffd6d2ab0a0b0f77320da) refactor: abstracted menu sizes away in a separate class - [`6f590b3`](https://github.com/AppFlowy-IO/AppFlowy/commit/6f590b30c3dcef8b23b4ed895170b92b386dd82d) test: updated integration test with the latest shortcut - [`6ce6679`](https://github.com/AppFlowy-IO/AppFlowy/commit/6ce6679037c1ba965ec442a9c0ba1738bf8efd25) Update frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/emoji_picker/emoji_menu_item.dart - [`18274d0`](https://github.com/AppFlowy-IO/AppFlowy/commit/18274d0db16edfc9145d9eebb80be1d16fd09cd4) refactor: changed to get context from editor state - [`a7cdf65`](https://github.com/AppFlowy-IO/AppFlowy/commit/a7cdf6599a532f34b14bd18a323a26a06e75cfcd) Merge branch 'main' into develop_emoji_shortcut_2038 ### 📊 Changes **8 files changed** (+149 additions, -11 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/command_shortcut_tests.dart` (+61 -0) 📝 `frontend/appflowy_flutter/integration_test/runner.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/emoji_picker/emoji_menu_item.dart` (+3 -3) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/emoji_picker/emoji_shortcut_event.dart` (+67 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/plugins.dart` (+1 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/layout/sizes.dart` (+6 -0) 📝 `frontend/rust-lib/Cargo.lock` (+8 -8) </details> ### 📄 Description   ### Feature Preview  fixes https://github.com/AppFlowy-IO/AppFlowy/issues/2038 ---  #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>