[PR #2563] [MERGED] fix: Text in `Show menu` tooltip does not get translated #5303

New issue

Closed

opened 2026-03-23 22:18:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2563
Author: @gitstart
Created: 5/18/2023
Status: ✅ Merged
Merged: 5/19/2023
Merged by: @LucasXu0

Base: main ← Head: FLOWY-OSS-24

📝 Commits (1)

88cf285 fix: Text in Show menu tooltip does not get translated

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 frontend/appflowy_flutter/assets/translations/en.json (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/more/more_button.dart (+3 -0)

📄 Description

fixes 2041

PR Description

The PR will add a toolkit widget as the parent of the Show menu icon so that it can be translated into different languages

Issue Video

https://www.loom.com/share/1f18cd24bf9746ffa4ae764814bbe38c

Fix Video

https://www.loom.com/share/4ffbe35db90d463e8580d0558cf4946d

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2563 **Author:** [@gitstart](https://github.com/gitstart) **Created:** 5/18/2023 **Status:** ✅ Merged **Merged:** 5/19/2023 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `FLOWY-OSS-24` --- ### 📝 Commits (1) - [`88cf285`](https://github.com/AppFlowy-IO/AppFlowy/commit/88cf2854bbab17e8c75920bbf2c90f8bafa5d8bc) fix: Text in Show menu tooltip does not get translated ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/assets/translations/en.json` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/more/more_button.dart` (+3 -0) </details> ### 📄 Description fixes [2041](https://github.com/AppFlowy-IO/AppFlowy/issues/2041) ### PR Description The PR will add a toolkit widget as the parent of the `Show menu` icon so that it can be translated into different languages ### Issue Video https://www.loom.com/share/1f18cd24bf9746ffa4ae764814bbe38c ### Fix Video https://www.loom.com/share/4ffbe35db90d463e8580d0558cf4946d --- ### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>