[PR #2564] [MERGED] chore: Edit Row changes #5304

New issue

Closed

opened 2026-03-23 22:18:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 22:18:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/2564
Author: @Ascarbek
Created: 5/18/2023
Status: ✅ Merged
Merged: 5/27/2023
Merged by: @appflowy

Base: develop ← Head: fix/tauri-board

📝 Commits (10+)

0b12f45 chore: checklist value and popup
3f42229 chore: properties side panel
004ad86 chore: reorganize checklist field
dd9ba8a chore: delete property promt
55e79a1 chore: delete property reorganize
c577cb5 fix: dnd bug of checklist field
7051684 fix: whitespace on empty fields
c4e2f82 chore: new checklist item
32496b4 fix: duplicate view
b7c2e8c fix: named checklist bars

📊 Changes

66 files changed (+1282 additions, -433 deletions)

View changed files

📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/Button.tsx (+6 -1)
➕ frontend/appflowy_tauri/src/appflowy_app/components/_shared/CheckListProgress.tsx (+27 -0)
➖ frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CellOptionsPopup.tsx (+0 -156)
➕ frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/CheckList.tsx (+40 -0)
➕ frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/CheckListOption.tsx (+60 -0)
➕ frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/CheckListPopup.tsx (+97 -0)
➕ frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/EditCheckListPopup.tsx (+94 -0)
➕ frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/NewCheckListButton.tsx (+28 -0)
➕ frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/NewCheckListOption.tsx (+53 -0)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/DateFormatPopup.tsx (+3 -3)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/DatePickerPopup.tsx (+1 -1)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/DateTimeFormat.hooks.ts (+0 -0)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/DateTypeOptions.tsx (+5 -8)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/EditCellDate.tsx (+4 -4)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/NumberFormat.hooks.ts (+1 -4)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/NumberFormatPopup.tsx (+2 -2)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/TimeFormatPopup.tsx (+3 -3)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/EditCellWrapper.tsx (+30 -16)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/EditFieldPopup.tsx (+2 -24)
📝 frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/EditRow.tsx (+216 -122)

...and 46 more files

📄 Description

Feature Preview

This PR partly fixes:
2426
2431
2406 (duplicate fixed, delete is backend issue WIP)

Includes:

redesign of Edit Row windows used in both Grid and Board
DnD of columns
Side panel for fields with only delete field support for now
CheckList field type. Adding a new option to checklist doesn't not update the field, need to refresh page to see the change. This is a backend issue (WIP)

PR Checklist

My code adheres to the AppFlowy Style Guide
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/2564 **Author:** [@Ascarbek](https://github.com/Ascarbek) **Created:** 5/18/2023 **Status:** ✅ Merged **Merged:** 5/27/2023 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `develop` ← **Head:** `fix/tauri-board` --- ### 📝 Commits (10+) - [`0b12f45`](https://github.com/AppFlowy-IO/AppFlowy/commit/0b12f4516db861a26e0b5a94aa6f45c2be7c34d9) chore: checklist value and popup - [`3f42229`](https://github.com/AppFlowy-IO/AppFlowy/commit/3f4222901cbd73efe3b2d8d45a3cd807eb5b0604) chore: properties side panel - [`004ad86`](https://github.com/AppFlowy-IO/AppFlowy/commit/004ad869234d30d7d645c223fa57af97ed59274d) chore: reorganize checklist field - [`dd9ba8a`](https://github.com/AppFlowy-IO/AppFlowy/commit/dd9ba8a0986eeb6ffe4e6785c675d28aacb074c0) chore: delete property promt - [`55e79a1`](https://github.com/AppFlowy-IO/AppFlowy/commit/55e79a17b668fcf6c0074b8669d744cda3d4296a) chore: delete property reorganize - [`c577cb5`](https://github.com/AppFlowy-IO/AppFlowy/commit/c577cb58ae6cd5b0949ee934f77fb343833b007c) fix: dnd bug of checklist field - [`7051684`](https://github.com/AppFlowy-IO/AppFlowy/commit/705168479569d6dbdb8433b970dda7183fea6268) fix: whitespace on empty fields - [`c4e2f82`](https://github.com/AppFlowy-IO/AppFlowy/commit/c4e2f8228623ee12df01b36f513289466e44f63c) chore: new checklist item - [`32496b4`](https://github.com/AppFlowy-IO/AppFlowy/commit/32496b46c9e71a57d686b37fda6fe750e34e57e8) fix: duplicate view - [`b7c2e8c`](https://github.com/AppFlowy-IO/AppFlowy/commit/b7c2e8ce3739b664e13ee823167076c287dcd840) fix: named checklist bars ### 📊 Changes **66 files changed** (+1282 additions, -433 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/Button.tsx` (+6 -1) ➕ `frontend/appflowy_tauri/src/appflowy_app/components/_shared/CheckListProgress.tsx` (+27 -0) ➖ `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CellOptionsPopup.tsx` (+0 -156) ➕ `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/CheckList.tsx` (+40 -0) ➕ `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/CheckListOption.tsx` (+60 -0) ➕ `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/CheckListPopup.tsx` (+97 -0) ➕ `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/EditCheckListPopup.tsx` (+94 -0) ➕ `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/NewCheckListButton.tsx` (+28 -0) ➕ `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/CheckList/NewCheckListOption.tsx` (+53 -0) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/DateFormatPopup.tsx` (+3 -3) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/DatePickerPopup.tsx` (+1 -1) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/DateTimeFormat.hooks.ts` (+0 -0) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/DateTypeOptions.tsx` (+5 -8) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/EditCellDate.tsx` (+4 -4) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/NumberFormat.hooks.ts` (+1 -4) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/NumberFormatPopup.tsx` (+2 -2) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/Date/TimeFormatPopup.tsx` (+3 -3) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/EditCellWrapper.tsx` (+30 -16) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/EditFieldPopup.tsx` (+2 -24) 📝 `frontend/appflowy_tauri/src/appflowy_app/components/_shared/EditRow/EditRow.tsx` (+216 -122) _...and 46 more files_ </details> ### 📄 Description ### Feature Preview This PR partly fixes: 2426 2431 2406 (duplicate fixed, delete is backend issue WIP) Includes: - redesign of Edit Row windows used in both Grid and Board - DnD of columns - Side panel for fields with only delete field support for now - CheckList field type. Adding a new option to checklist doesn't not update the field, need to refresh page to see the change. This is a backend issue (WIP) #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>